Keep sidebar footer controls at a 24px pointer target - #395
Merged
Merged
Conversation
A new rendered test measures every pointer target at the default and the minimum window size against WCAG 2.5.8: a target under 24px passes only if a 24px circle on it touches no other target. Inline links are exempt, a checkbox is measured with its label, and folded disclosures are opened. It found the footer's stacked disclosures too tight: "Keyboard shortcuts" was a 17px strip against "User settings", and "Show archived chats" a 15px label under it. The summaries take a 24px line and the label a 24px row. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The end-to-end coverage has unresolved threshold, geometry, and compact-viewport issues.
Review effort: Lite
Findings: None
What changed in this PR
Improves sidebar footer pointer-target sizing for WCAG 2.5.8 and adds responsive end-to-end coverage.
Changes:
- Sets footer controls to 24px target sizes.
- Adds pointer-target validation at desktop and minimum viewport sizes.
| File | Description |
|---|---|
src/coven/chat-app.css |
Enlarges footer control hit areas. |
e2e/app.tauri-mock.spec.ts |
Adds WCAG pointer-target validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
New test. A rendered e2e test measures every pointer target against WCAG 2.5.8 at two window sizes: the default and the 480×520 minimum. A target smaller than 24px passes only if a 24px circle centred on it touches no other target.
Fixes the test found: the controls in the sidebar footer were packed too tightly.
Verification
playwright test: 61 passed.Show archived chats: 137x15andKeyboard shortcuts: 123x17.vitest run src/coven: 271 passed.chat-app.css.🤖 Generated with Claude Code