Skip to content

Record the #40 disposition for replacement candidate cd10a3f: SHIP - #326

Merged
BunsDev merged 2 commits into
mainfrom
docs/sdk40-cd10a3f-disposition
Sep 26, 2026
Merged

BunsDev merged 2 commits into
mainfrom
docs/sdk40-cd10a3f-disposition

Conversation

@BunsDev

@BunsDev BunsDev commented Sep 26, 2026

Copy link
Copy Markdown
Member

Part of #40. This updates docs/workflows/first-release-security-review.md with the review of replacement candidate cd10a3f and a fresh disposition.

Disposition: SHIP (recommended) for cd10a3fa1d9900e0dbcb04bbb2477140854fba1d.

Evidence

Findings

  • R1 (Low). The managed familiarContract and familiarAnalytics bypass the JS downgrade guard and iterator pin. This is confirmed at cave/src/managed.ts:144-145. The exposure depends on the host, which owns discovery and the bearer in managed mode.
    • Accepted by the release owner on 2026-09-26.
    • Follow-up due 2026-10-24: route both reads through the resolver, or record the host guarantee.
  • I1–I3 (Informational), accepted:
    • the managed latch is per client instance;
    • the HPKE proof is asserted by the host;
    • an abandoned event iterator keeps one abort listener.
  • F3 carries forward, with this cycle's two local timeout recurrences noted.

Scope of the decision

This does not authorize publication. publishingEnabled stays false and the packages stay private. Publication remains with #41, which needs its own fresh authorization, the protected approval chain, npm trusted-publisher confirmation and registry byte/provenance checks. The previous candidate 96804bc4 stays blocked, and its record is kept as history.

Docs only.

🤖 Generated with Claude Code

cd10a3f has a passing, attested, live-verified aggregate (#325), and its
packed bytes carry the F4, F5 and F1 fixes that blocked 96804bc. Automated
checks pass at the candidate commit, and an independent review of the
runtime code added since aec0690 finds one Low item (R1: managed
familiarContract and familiarAnalytics skip the JS downgrade guard), which
the release owner accepted with a follow-up due 2026-10-24, plus three
informational notes. Publication stays gated by #41.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 26, 2026 07:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Add exact verification evidence, reconcile current-status documentation, and correct the lifecycle-script wording.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates the first-release security record with a recommended SHIP disposition for candidate cd10a3f, while keeping publication separately gated.

Changes:

  • Records packaging, conformance, automated-check, and manual-review evidence.
  • Documents accepted findings and follow-up dates.
  • Preserves publication gating through #41 and the history of candidate 96804bc4.
File Summary
docs/​workflows/​first-release-security-review.md Records the replacement candidate’s security review and SHIP disposition.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/workflows/first-release-security-review.md Outdated
…ripts

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@BunsDev
BunsDev merged commit 6b6fa18 into main Sep 26, 2026
8 checks passed
@BunsDev
BunsDev deleted the docs/sdk40-cd10a3f-disposition branch September 26, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants