Repository navigation
Record the #40 disposition for replacement candidate cd10a3f: SHIP - #326
Merged
Merged
Conversation
cd10a3f has a passing, attested, live-verified aggregate (#325), and its packed bytes carry the F4, F5 and F1 fixes that blocked 96804bc. Automated checks pass at the candidate commit, and an independent review of the runtime code added since aec0690 finds one Low item (R1: managed familiarContract and familiarAnalytics skip the JS downgrade guard), which the release owner accepted with a follow-up due 2026-10-24, plus three informational notes. Publication stays gated by #41. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add exact verification evidence, reconcile current-status documentation, and correct the lifecycle-script wording.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the first-release security record with a recommended SHIP disposition for candidate cd10a3f, while keeping publication separately gated.
Changes:
- Records packaging, conformance, automated-check, and manual-review evidence.
- Documents accepted findings and follow-up dates.
- Preserves publication gating through #41 and the history of candidate
96804bc4.
| File | Summary |
|---|---|
docs/workflows/first-release-security-review.md |
Records the replacement candidate’s security review and SHIP disposition. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ripts Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of #40. This updates
docs/workflows/first-release-security-review.mdwith the review of replacement candidatecd10a3fand a fresh disposition.Disposition: SHIP (recommended) for
cd10a3fa1d9900e0dbcb04bbb2477140854fba1d.Evidence
cave-clientdist/: F4 (fix(cave): retain observed discovery authority #277 latch), F5 (fix(cave): redact protected fetch error causes #285 cause redaction) and F1 (fix(cave): stop advising retry on timed-out single-use pairing exchange #294).399e1f19, validator67fd5d8a). It was verified live, and strict readiness passes.cd10a3f:pnpm audit, with no known vulnerabilities;release.yml;aec069089..cd10a3f(feat(coven): add bounded Automation event subscriptions #300, feat(cave): preserve managed HPKE iterator authority #301, feat(coven): verify local Automation receipt integrity #304, feat(coven): add bounded Automation digest and projection helpers #305, build(deps): bump canonicalize from 5.0.0 to 5.1.0 #308). It found no Critical, High or Medium issue.Findings
familiarContractandfamiliarAnalyticsbypass the JS downgrade guard and iterator pin. This is confirmed atcave/src/managed.ts:144-145. The exposure depends on the host, which owns discovery and the bearer in managed mode.Scope of the decision
This does not authorize publication.
publishingEnabledstaysfalseand the packages stay private. Publication remains with #41, which needs its own fresh authorization, the protected approval chain, npm trusted-publisher confirmation and registry byte/provenance checks. The previous candidate96804bc4stays blocked, and its record is kept as history.Docs only.
🤖 Generated with Claude Code