fix(coven): check occurrence-history order by instant, not text - #332
Merged
Merged
Conversation
Scheduled occurrences store millisecond and manual ones nanosecond RFC 3339, so byte order refused valid mixed pages. Compare the producer's sort key (fraction padded to nine digits) instead, with id breaking equal instants, matching OpenCoven/coven#1158. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered by tests and no unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates occurrence-history validation to match producer ordering by normalized timestamp instant, with id tie-breaking.
Changes:
- Normalize timestamp fractions to nanoseconds.
- Add regression coverage for mixed precision and equal instants.
- Update documentation and release changeset.
| File | Description |
|---|---|
tests/coven-automations.spec.ts |
Tests corrected ordering behavior. |
packages/coven/src/automations-occurrences.ts |
Implements normalized instant ordering. |
packages/coven/README.md |
Documents instant-based ordering. |
.changeset/coven-history-instant-order.md |
Records the patch release. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #331, part of #80.
Copilot found on OpenCoven/coven#1158 that manual occurrences store nanosecond RFC 3339 and scheduled ones millisecond. Raw text order therefore misplaces rows within one millisecond:
.123Zsorts above.123100000Z. The producer now orders and pages by the instant, padding the fraction to nine digits and breaking equal instants byid.#331's newest-first check compared raw
scheduledForbytes, so it would refuse those correct mixed pages. This PR compares the same key the producer's SQL builds, character for character, withidstill breaking equal instants.Verification
pnpm verifypassed (3034 tests, lint, coverage, stress, contracts, package).id, and a whole-second value, and checks that the reversed pairs are refused.🤖 Generated with Claude Code