Skip to content

feat: refactor attachment handling#617

Merged
najuna-brian merged 8 commits intoOpenDataEnsemble:devfrom
HelloSapiens:fix/desktop-attachments
Apr 17, 2026
Merged

feat: refactor attachment handling#617
najuna-brian merged 8 commits intoOpenDataEnsemble:devfrom
HelloSapiens:fix/desktop-attachments

Conversation

@r0ssing
Copy link
Copy Markdown
Contributor

@r0ssing r0ssing commented Apr 17, 2026

This PR aims to unify the way attachments are handled across clients (desktop/formulus).
There are 3 folders:

  • attachments/drafts (for unsaved attachments)
  • attachments/pending (for stuff pending upload)
  • attachments/synced (for synced attachments)

The correct (and only) way to get the full URI is to ask formulus API (getAttachmentUri(filename))

najuna-brian
najuna-brian previously approved these changes Apr 17, 2026
@najuna-brian najuna-brian self-requested a review April 17, 2026 15:46
Copy link
Copy Markdown
Contributor

@najuna-brian najuna-brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r0ssing

@najuna-brian najuna-brian merged commit a4d1ffd into OpenDataEnsemble:dev Apr 17, 2026
15 checks passed
@r0ssing r0ssing deleted the fix/desktop-attachments branch April 17, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants