Skip to content

Conversation

@HeDo88TH
Copy link
Contributor

  • Fixed DroneDB integration
  • Added support to specify org/dataset when publishing

@pierotofy
Copy link
Member

Nice, is this ready or still a draft?

@HeDo88TH
Copy link
Contributor Author

Nice, is this ready or still a draft?

I have tested it but I need to do more thorough testing before marking it as ready

@HeDo88TH HeDo88TH changed the title Improved dronedb plugin Improved DroneDB plugin Dec 11, 2025
@HeDo88TH HeDo88TH marked this pull request as ready for review December 24, 2025 13:49
Copilot AI review requested due to automatic review settings December 24, 2025 13:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the DroneDB plugin by fixing integration issues and adding the ability to specify organization and dataset when sharing data to DroneDB. The changes introduce a new ShareDialog component that provides users with two sharing modes: a quick share option that auto-generates destinations, and a manual selection mode that allows choosing specific organizations and datasets.

Key Changes:

  • Added a new ShareDialog component with organization/dataset selection UI
  • Updated the share API to accept optional 'tag' and 'datasetName' parameters
  • Improved code formatting and replaced loose equality operators with strict equality

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
coreplugins/dronedb/public/components/ShareDialog.jsx New modal dialog component for selecting share destination with organization/dataset dropdowns
coreplugins/dronedb/public/components/ShareDialog.scss Styling for the new ShareDialog component
coreplugins/dronedb/public/ShareButton.jsx Updated to integrate ShareDialog and pass tag/datasetName parameters; improved code quality with strict equality
coreplugins/dronedb/api_views.py Modified share endpoint to accept and forward tag/datasetName parameters; improved formatting
coreplugins/dronedb/ddb.py Updated share_init method to accept tag and dataset_name parameters; improved code formatting
coreplugins/dronedb/plugin.py Updated build configuration to include new ShareDialog component and CSS; improved formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants