Repository navigation
Judge tuning (1/5): Fix vLLM compatibility and context failures - #138
Open
ErlisLushtaku wants to merge 8 commits into
Open
ErlisLushtaku wants to merge 8 commits into
ErlisLushtaku wants to merge 8 commits into
Conversation
This was referenced Oct 8, 2026
This was referenced Oct 9, 2026
This was referenced Oct 13, 2026
ErlisLushtaku
marked this pull request as ready for review
October 13, 2026 12:51
kargibora
reviewed
Oct 15, 2026
| results = [] | ||
| for out in outputs: | ||
| if out is None: | ||
| results.append(InferenceResult(text="", error="context_length")) |
Member
There was a problem hiding this comment.
Are we sure the error is context length?
Collaborator
Author
There was a problem hiding this comment.
Yes, the None comes from _run_raw_batch, where we leave an empty slot for requests rejected for exceeding the context limit and fill in the results for the valid ones. Other errors are raised there, so they don't reach this loop.
| vllm = [ | ||
| "vllm>=0.19.1,<1.0.0", | ||
| "transformers>=5.5.1,<6.0.0", | ||
| "openai>=2.30.0", # vLLM 0.25 imports responses.NamespaceTool. |
Member
There was a problem hiding this comment.
This doesnt break anything right?
Collaborator
Author
There was a problem hiding this comment.
Seems fine with the current dependencies. I tried a clean install with both extras. Also the tests pass. This resolved to vllm==0.32.0 and openai==3.35.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two vLLM problems that judge tuning runs into.
responses.NamespaceToolfrom the OpenAI SDK, so thevllmextra now requiresopenai>=2.30.0.LLM.chat()fail the whole batch. Each chat request is now length-checked first, and overlong ones come back as failed annotations (error="context_length") while the valid requests still run. A search will hit this on long conversations, and one bad battle should not fail a whole trial. The check uses a private vLLM method (_preprocess_chat_one), which exists in 0.19 to 0.25.Merge order: #138 → #135 → #140 → #133 → #136.