Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds FSDP (v1 or v2, via
fsdp.version) as an alternative to DeepSpeed for containerized TRL runs. The newfsdp:block is passed toaccelerate launchas--fsdp_*flags;nullkeeps the current behavior._no_split_modules), checkpointstate_dict_type(sharded by default), prefetch, offload, rank-0 loading, and activation checkpointing. The settings go on the launch line, not intoTrainingArguments, because TRL loads the model before theAcceleratorexists.deepspeed+fsdp, nocontainer.image(only the container template renders the flags), orbackend: llamafactoryNO_SHARD/HYBRID_*, andcpu_ram_efficient_loadingwithoutsync_module_statesearly_stop: false: early stopping makes collectives rank-dependent when sequence lengths differsft.yaml/dpo.yamlshow the block as a commented alternative.Type of change
Validation
pytest: 229 passed, with new tests for validation, rendered launch flags, and the checkpoint gather.FSDP requires a single root module), hence the rejection.