Repository navigation
Drop unpublished vertx test modules from feign-bom - #3601
Merged
Merged
Conversation
Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feign-bommanagesfeign-vertx4-testandfeign-vertx5-test, but the release never deploys them. The CircleCI deploy excludes them with-pl -:feign-vertx4-test,-:feign-vertx5-test. Those coordinates have returned 404 on Maven Central since at least 13.14, so anyone who declares them through the BOM gets a resolution failure.generate-bomexcludes now include*:feign-vertx*-test, so a regenerated BOM can't bring them back.feign-bom/pom.xml. Its dependency list now matches the generator output exactly.Checked and left as-is:
feign-spring4is a relocation stub that points atfeign-spring, so the BOM correctly leaves it out.feign-graphql-aptandfeign-apt-test-generatorare published underio.github.openfeign.experimental, outside the BOM'sio.github.openfeign:*scope.Verified:
mvn -pl feign-bom installbuilds, and every one of the 42 artifacts in the flattened BOM resolves on Maven Central at 13.16.