Repository navigation
Handle primitive array form values without reference-array casts - #3608
Merged
velo merged 3 commits intoOct 7, 2026
Merged
Conversation
Read primitive and reference array elements through Array, retaining collection formatting and multipart binary writer priority. Add encoder regressions and a changelog entry. Fixes OpenFeign#3607
velo
approved these changes
Oct 7, 2026
…old primitive-array tests into existing suites Signed-off-by: Marvin Froeder <velo.br@gmail.com>
Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Form values such as
int[]pass the array check but then throwClassCastExceptionwhen URL-encoded and multipart processors cast them toObject[].Read array elements through
java.lang.reflect.Array, preserving URL-encodedCollectionFormatand existing multipart writer ordering. Numeric and boolean multipart arrays produce repeated scalar parts;byte[]retains its existing single binary part. Reference arrays, collections and scalar behavior remain covered.Fixes #3607.
Validation in a standalone checkout on JDK 26:
./mvnw -q -Pdev -Dtoolchain.skip=true -Dmaven.compiler.proc=full -pl form -am verify: 882 tests passed, 4 skipped across core, jackson and form; license and formatting checks enabled.proc=fullenables Lombok processing on the installed JDK; main source retains the project's Java 8 target. This is affected-module validation, not an all-module build.AI assistance: DeepSeek assisted implementation, tests and initial review; Codex coordinated validation and submission.