Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: two callers share one client and both
GET /things/42; the origin answers the first withCache-Control: private,ETag: "v1"and that caller's data, then answers the second caller's revalidation with304.Expected: the second caller gets its own data, or the
304surfaces.Actual: the second caller is handed the first caller's decoded object.
Cause:
maybeStoreonly refusesno-store, so aprivateresponse (RFC 9111 5.2.2.7, a shared cache must not store it) and aVary: *response (RFC 9111 4.1,*never matches a later request) both land in theHttpCacheStoreevery caller of the client shares, under a default key ofconfigKey|METHOD url[|body hash]that carries no request header. The stored validator then goes out on the next caller's request asIf-None-Match.Fix: treat both as unstorable alongside
no-store.Varyfield names other than*are untouched, soVary: Accept-Encodingand friends still cache as before, and the README caveat about uninterpretedCache-Controldirectives is narrowed to freshness, which revalidation already covers.