Docs for installing optional dependencies and better handling of pygraphviz optional deps#141
Merged
Conversation
IAlibay
commented
Jun 1, 2026
| else: | ||
| return False | ||
|
|
||
| @requires_package("pygraphviz") |
Member
Author
There was a problem hiding this comment.
None of the GraphGen code is directly tested (especially all the viz outputs) - I tested executing dbmol locally and all these worked as expected with and without pygraphviz.
I'm not sure it's really worth adding the extra tests, but can be convinced.
Contributor
There was a problem hiding this comment.
I think this is fine as-is for now.
Member
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
… into pygraphviz-optional
atravitz
approved these changes
Jun 1, 2026
Contributor
atravitz
left a comment
atravitz
left a comment
There was a problem hiding this comment.
Just a couple suggestions, not blocking though.
| Optional Dependencies | ||
| --------------------- | ||
|
|
||
| ``lomap2`` has optional software dependencies which can be installed to extend |
Contributor
There was a problem hiding this comment.
Is there consistency as to when we say Lomap vs lomap2?
| else: | ||
| return False | ||
|
|
||
| @requires_package("pygraphviz") |
Contributor
There was a problem hiding this comment.
I think this is fine as-is for now.
Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.