G2P-5619 Add database connection pooling to master-data API - #17
Merged
shibu-narayanan merged 1 commit intoSep 4, 2026
Merged
Conversation
… API - Introduced SQLAlchemy connection pool settings in values.yaml and .env.example. - Updated G2PAttributeService and G2PGeoService to utilize the new async session maker for database interactions. - Removed deprecated engine.py file as its functionality is now handled by the updated session management approach in fastapi-commons
tahzeer
marked this pull request as draft
September 3, 2026 11:31
tahzeer
marked this pull request as ready for review
September 4, 2026 04:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G2P-5619
important note
get_async_session_makerfrom fastapi-commonsthis pr should only be merged when the said commit 17057b is merged into the referenced fastapi-common branch or tag used in this repo or else apis will fail to create a session