Skip to content

Default working dir to workspace/project#63

Merged
neubig merged 2 commits intomainfrom
fix/relative-working-dir-default
May 1, 2026
Merged

Default working dir to workspace/project#63
neubig merged 2 commits intomainfrom
fix/relative-working-dir-default

Conversation

@neubig
Copy link
Copy Markdown
Collaborator

@neubig neubig commented May 1, 2026

Summary

  • change the default agent-server working directory fallback to workspace/project
  • reuse the shared default in git-path heuristics and the default PLAN preview path
  • update tests and developer docs to match the new default

Verification

  • npm test
  • npm run typecheck && npm run build

This PR was created by an AI agent (OpenHands) on behalf of the user.

Co-authored-by: openhands <openhands@all-hands.dev>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-server-gui Ready Ready Preview, Comment May 1, 2026 5:56am

Request Review

Copy link
Copy Markdown

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste — Clean refactoring that eliminates magic strings and centralizes the default working directory path.

The change from absolute to relative path is well-documented, consistently applied across all references (code, tests, docs), and users can still override via VITE_WORKING_DIR.

[RISK ASSESSMENT]
🟢 LOW — Simple refactoring that replaces hardcoded paths with a constant. No behavior changes beyond the path format (absolute → relative), which is documented and overridable.

VERDICT:
Worth merging — Solid refactoring with comprehensive updates and good test coverage.

KEY INSIGHT:
Centralizing configuration constants is a best practice that makes future changes easier and reduces the risk of inconsistencies.

@neubig neubig merged commit 68c2b25 into main May 1, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants