Skip to content

refactor(frontend): remove legacy max-budget settings control - #213

Merged
saurya merged 3 commits into
mainfrom
remove-v1-max-budget-control
Aug 27, 2026
Merged

refactor(frontend): remove legacy max-budget settings control#213
saurya merged 3 commits into
mainfrom
remove-v1-max-budget-control

Conversation

@saurya

@saurya saurya commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

HUMAN:

  • A human has tested these changes.

AGENT:
OpenHands


Why

The max-budget-per-conversation input is a legacy control shown only when v1_enabled is false. Conversation creation now uses V1 regardless of this setting, so the control and its form plumbing are obsolete.

Summary

  • Remove the conditional max-budget input from application settings.
  • Stop including the absent field in application-settings saves.
  • Remove the unused parser and its tests, with route coverage for legacy false settings.

Issue Number

N/A

How to Test

  • cd frontend && npm test -- __tests__/routes/app-settings.test.tsx __tests__/utils/settings-utils.test.ts
  • cd frontend && npm run lint
  • cd frontend && npm run build
  • pre-commit run --config ./dev_config/python/.pre-commit-config.yaml

Video/Screenshots

Not included; this removes a control reachable only through legacy false settings.

Type

  • Bug fix
  • Feature
  • Refactor
  • Breaking change
  • Docs / chore

Notes

This is the first PR in a three-PR stack. Follow-ups remove frontend v1_enabled gates, then the remaining compatibility surface.

This PR was created by an AI agent (OpenHands) on behalf of the user.


Enterprise server image for this PR:

ghcr.io/openhands/enterprise-server:sha-88d1976

Co-authored-by: openhands <openhands@all-hands.dev>
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

Coverage report

This PR does not seem to contain any modification to coverable code.

@saurya saurya changed the title Remove legacy max-budget settings control refactor(frontend): remove legacy max-budget settings control Aug 20, 2026
@github-actions github-actions Bot added the type: refactor Code refactoring label Aug 20, 2026
@saurya
saurya requested a review from malhotra5 August 25, 2026 01:25
@saurya
saurya marked this pull request as ready for review August 25, 2026 01:25
@saurya
saurya merged commit 86367c6 into main Aug 27, 2026
21 of 22 checks passed
@saurya
saurya deleted the remove-v1-max-budget-control branch August 27, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants