chore: remove Reo tracking integration - #227
Conversation
Remove the production Reo script and identity tracking from the enterprise frontend.\n\nCo-authored-by: openhands <openhands@all-hands.dev>
|
✅ Review complete. This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here. |
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Taste Rating: Good taste — this is the simplest safe fix: remove the buggy third-party tracking script and its call sites instead of adding defensive wrappers around an untrusted CDN integration.
[REVIEW SUMMARY]
- Removed the Reo CDN loader, identity hook, global
Window.Reodeclaration, root-layout hook call, and obsolete test mock as one coherent cleanup. - Verified there are no remaining Reo references in the repository and no dependency or lockfile changes to review for supply-chain risk.
- Existing frontend root-layout coverage remains in place with the obsolete mock removed. GitHub checks show frontend unit/e2e, lint, Python tests, package-version checks, and Docker image builds passing; the separate QA automation check was still pending at review time.
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
This is a deletion-only frontend cleanup of an isolated SaaS tracking integration. The main behavior change is the intended loss of Reo analytics/identify events; no public APIs, backend paths, migrations, auth flows, or dependency versions are touched.
VERDICT:
✅ Worth merging: Core logic is sound; wait for the pending QA check if branch protection requires it.
KEY INSIGHT:
The PR has good taste because it eliminates the side-effect source entirely rather than trying to tame a third-party script that was already breaking browser APIs.
This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation
|
needs human approval All branch code checks are green, automated review approved the current SHA, and there are zero unresolved review threads. QA failed on the initial run plus all 3 allowed reruns because the all-hands-bot GitHub API quota is exhausted (HTTP 403). The approval-triggered PR Artifacts cleanup also failed because its checkout token input was unavailable. A maintainer needs to restore the bot quota/workflow credentials and rerun these workflows. This comment was created by an AI agent (OpenHands) on behalf of the user. |
Summary
This removes the third-party script that currently produces Permissions.query Illegal invocation errors on app.all-hands.dev.
Validation
Context
PostHog traces the error to static.reo.dev/6bac7145b4ee6ec/177.reo.js, where Reo overrides Permissions.query. This PR removes the integration so the question of whether Reo should remain can be resolved during review.
This pull request was created by an AI agent (OpenHands) on behalf of the user.
Enterprise server image for this PR: