Skip to content

Make windows install work through rimraf#137

Merged
neubig merged 2 commits intomainfrom
make-windows-install-work
Apr 27, 2026
Merged

Make windows install work through rimraf#137
neubig merged 2 commits intomainfrom
make-windows-install-work

Conversation

@neubig
Copy link
Copy Markdown
Contributor

@neubig neubig commented Apr 27, 2026

  • A human has tested these changes.

Why

npm install was not working on windows due to platform-incompatible rm -rf.

Summary

  • uses the rimraf library instead

Type

  • Bug fix
  • Feature
  • Refactor
  • Breaking change
  • Docs / chore

@neubig
Copy link
Copy Markdown
Contributor Author

neubig commented Apr 27, 2026

@OpenHands fix merge conflicts and merge this PR in to main.

@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 27, 2026

I'm on it! neubig can track my progress at all-hands.dev

@neubig neubig merged commit 748db5f into main Apr 27, 2026
6 checks passed
@openhands-ai
Copy link
Copy Markdown

openhands-ai Bot commented Apr 27, 2026

Final update since my last summary:

  • Fully addressed the request:

    • Resolved the merge conflicts on make-windows-install-work
    • Preserved the Windows fix (rimraf dist) while keeping main's dependency updates
    • Verified locally with npm ci, npm run build, and npm test
    • Pushed the fix to the PR branch
    • Waited for GitHub CI to finish successfully
    • Merged PR Make windows install work through rimraf #137 into main
  • Instructions were followed faithfully:

    • Used GitHub API/CLI rather than browser flows
    • Updated the existing PR branch instead of creating a new PR
    • Did not push directly to main
    • Merged only after the PR became clean and checks passed
  • Changes were concise:

    • Only the conflicted dependency files were touched as part of conflict resolution
    • No extraneous repository changes were introduced beyond what was necessary to reconcile main with the rimraf fix

New final state:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants