Guard serial read against pyserial blocking indefinitely#45
Merged
Conversation
Wrap run_in_executor with asyncio.wait_for so that if pyserial's read() blocks despite the timeout (e.g. device reboots mid-transfer), the protocol fails cleanly instead of hanging forever. The guard timeout is 2x the pyserial timeout + 1s, so it only fires when pyserial itself is stuck. Tested on hi3516av300 hardware — no interference with normal operation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_in_executor(pyserial.read)withasyncio.wait_forso if pyserial blocks despite its timeout (e.g. device reboots mid-transfer), the protocol fails cleanly instead of hanging forever.2 * pyserial_timeout + 1s— only fires when pyserial itself is stuck.Previously, if a device rebooted during SPL transfer, defib would hang indefinitely waiting for an ACK that would never come.
Test plan
uv run pytest tests/ -x -v --ignore=tests/fuzz— 326 passed🤖 Generated with Claude Code