RustFS replaces MinIO; snapshot.sh finds the database the services actually use - #9
Merged
Merged
Conversation
Quay now answers an anonymous pull of quay.io/minio/minio with unauthorized, after Docker Hub stopped resolving minio/minio on 2026-09-16, and the binary archive answers 410. The Integration skeleton job has failed since. RustFS 1.0.0 passes the whole object-storage suite. SeaweedFS and Garage fail the signed browser upload; LocalStack serves a private object unsigned. The provider-gap test becomes a positive one: RustFS keeps an abort-incomplete rule beside an expiration rule, as Hetzner does in production. Self-host: the object-storage profile runs RustFS; setup gains a bucket CORS rule, because unlike MinIO it does not open CORS to every origin.
The previous commit carried only the two renames; this is the content it describes.
…xternal postgres_in_stack piped compose config into grep -q under pipefail. grep exits at its first match, compose can take SIGPIPE while still writing, and the pipeline then reads as no postgres: the bundled database was left out of the snapshot. Measured 26 wrong answers in 300; capturing the list first gives 0. A configuration compose cannot resolve is now an error, not an answer.
…hether postgres is defined A postgres service that is still defined while env/api.env names another host (NEON.md's step 5 skipped, or any managed Postgres) holds nothing the services write; archiving it was a snapshot of the wrong database, and a rollback would have restored it and started the stack against the untouched real one. Now that case is external, with a note naming the host (never the credentials). DATABASE_URL_FILE, which the host cannot read, falls back to the service. Proven on oa-ci: bundled -> volume (and 0/50 wrong over repeats), URL elsewhere -> external + note, restore of a volume snapshot there -> refused, DATABASE_URL_FILE -> volume, neon overlay -> external.
Contributor
|
Thanks for the pull request. Before it can be merged we need you to sign the Contributor License Agreement — once, ever, for every future contribution too. Read it, then post exactly this as a comment on this pull request: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
quay.io/minio/miniowithunauthorized(after Docker Hub on 2026-09-16), and the binary archive answers 410. The Integration skeleton job has been red onmainsince.snapshot.shcould leave a bundled Postgres out of a snapshot (introduced with the Neon work,2a00b12). Two defects, both fixed here.What
RustFS 1.0.0 instead of MinIO — CI, the object-storage test (renamed
object-storage-s3.test.ts), the self-hostobject-storageprofile, env templates,SELF-HOSTING.md, CHANGELOG. Candidates were run against the real suite (19 tests):latestonly — no version pinRustFS does not open CORS to every origin, so the self-host setup gains a bucket CORS rule (commands run against the real compose file: healthy → bucket → CORS → preflight answers the origin).
snapshot.shcompose config --services | grep -qx postgresunderpipefailmisread a bundled Postgres as external 26 times in 300; capturing the list first: 0 in 300.DATABASE_URLpoints, not only whether apostgresservice exists. Proven on oa-ci: bundled → volume (0/50 wrong over repeats); URL elsewhere with the service still defined → external + a note naming the host; restoring a volume snapshot there → refused;DATABASE_URL_FILE→ falls back to the service; Neon overlay → external.Proof
CI on this branch: 6/6 green (run).
Upgrade note
Only installs with the
object-storageprofile enabled have anything to do (in CHANGELOG[Unreleased]).🤖 Generated with Claude Code
Summary by CodeRabbit