Codex/libcamera rpi fix - #18
Open
jeremymcgee73 wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Raspberry Pi camera userspace startup on OpenMANET, and make the camera streaming service default to the OpenMANET HaLow-facing interface on Pi builds.
This MR contains the package-side changes required by the corresponding firmware-side Raspberry Pi camera enablement.
What this changes
libcamera
multimedia/libcamera/patches/0006-rpi-guard-empty-frame-length-queue.patchThis prevents an abort in the Raspberry Pi camera pipeline where
applyAGC()could callframeLengths_.pop_front()before the queue had been populated.bcm271x board defaults
boards/bsp-bcm271x/files/uci-defaults/20_camera-onvif-server-interfaceboards/bsp-bcm271x/files/hotplug.d/iface/95-camera-onvif-server-interfaceThese changes make
camera-onvif-serveruseahwlanon OpenMANET Pi images instead of the genericlandefault.Why
Before these changes:
camera-onvif-serverdefaulted tolanahwlan, so the service failed with:interface lan not readylansetting even after the image layout moved toahwlanAfter these changes:
ahwlanahwlancomes upScope
These interface-default and migration changes are intentionally limited to:
bsp-bcm271xThey are not applied globally to:
Validation
Validated on Raspberry Pi 4 / bcm2711 with IMX219:
cam -lreports the camera successfullyrpicamerapathrtsp://<device-ip>:554/rpicameraObserved failure before the
libcamerafix:std::deque::pop_front()from the RPi IPA path during stream startupObserved failure before the interface-default fix:
camera-onvif-serverattempted to uselanrpicamerapathpath 'rpicamera' is not configuredObserved success after these changes:
ahwlanrpicamerapath createdNotes
This MR is intended to pair with the corresponding
firmwareMR that:openmanetfeed to the package commit containing these fixes