Connect tile polygons from different layers#1
Open
elsid wants to merge 1 commit into
Open
Conversation
ed3f010 to
8473e87
Compare
Root cause: The connectExtLinks function (which links tiles at the same x,y position but different layers) only processes DT_EXT_LINK edges - edges where the polygon mesh touches the tile boundary. For the slope geometry in the test, the walkable area never reaches the tile boundary (it's eroded away), so no DT_EXT_LINK edges exist. As a result, layers -1 and 0 had no connections, causing findPath to return DT_PARTIAL_RESULT. Fix: Added a new connectLayerLinks(tile, target) function in DetourNavMesh.cpp that connects same-position tiles (different layers) by finding xz-overlapping polygons: * For each ground polygon in tile, compute its centroid. * Query findNearestPolyInTile in target with that centroid. * If the nearest polygon in target contains the centroid in xz (dxz < 1e-3) and the height difference is within walkableClimb, create a link with side=0xff (layer-to-layer connection). This is called bidirectionally (connectLayerLinks(tile, neis[j]) and connectLayerLinks(neis[j], tile)) from the same place existing layer connection code runs in addTile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes recastnavigation#818.
Root cause: The connectExtLinks function (which links tiles at the same x,y position but different layers) only processes DT_EXT_LINK edges - edges where the polygon mesh touches the tile boundary. For the slope geometry in the test, the walkable area never reaches the tile boundary (it's eroded away), so no DT_EXT_LINK edges exist. As a result, layers -1 and 0 had no connections, causing findPath to return DT_PARTIAL_RESULT.
Fix: Added a new connectLayerLinks(tile, target) function in DetourNavMesh.cpp that connects same-position tiles (different layers) by finding xz-overlapping polygons:
This is called bidirectionally (connectLayerLinks(tile, neis[j]) and connectLayerLinks(neis[j], tile)) from the same place existing layer connection code runs in addTile.