Skip to content

Conversation

@vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Dec 11, 2025

Previously the architecture-specific dynamic files were relying on the built-in rules alone.

Previously the architecture-specific dynamic files were relying on the
built-in rules alone.
@martin-frbg
Copy link
Collaborator

Sorry, I do not see what this would be fixing, when the built-in rule works fine (and has so for years)

@vtjnash
Copy link
Contributor Author

vtjnash commented Dec 15, 2025

I appreciate the quick review, but please reopen this. This was accidentally relying on an old-fashioned technique (not my name for it, literally that is what this feature is called https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html) that does not work reliably for many uses. In particular, the rule is only implemented when $(SUFFIX) is defined to be .o, but that means this one file breaks the build if any part of the Makefile uses a different SUFFIX value. This is a really simple fix for that.

@vtjnash
Copy link
Contributor Author

vtjnash commented Dec 22, 2025

Bump. Please reopen and merge this bugfix.

@martin-frbg
Copy link
Collaborator

Thanks for the explanation. Can you please let me know what environment/toolchain you are working with ? I assume it would have to be a Windows on Arm target environment (to require a specific dynamic_ARCH.c) and probably a cross-compiler that uses .obj extensions ?

@martin-frbg martin-frbg reopened this Dec 23, 2025
@vtjnash
Copy link
Contributor Author

vtjnash commented Dec 23, 2025

That is right. I'm using https://github.com/mstorsjo/llvm-mingw.git modified to add flang support (I have a PR there) to test various configurations of builds

@martin-frbg
Copy link
Collaborator

I see... I wasn't aware of that project, thanks for the pointer. (I guess you are aware that the native LLVM package for WoA does include flang already, unlike their Windows/x64 package ?)

@vtjnash
Copy link
Contributor Author

vtjnash commented Dec 23, 2025

Yes, I'm working on integration with Julia, which is still mostly Makefile driven, and thus very annoying to deal with on Windows natively. That project lets me use mingw as the libraries to be able to use it from linux (WSL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants