Skip to content

Remove redundant malloc in the f2c- converted LAPACK IPARAM2STAGE #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martin-frbg wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −10
Open

Remove redundant malloc in the f2c- converted LAPACK IPARAM2STAGE #6064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions lapack-netlib/SRC/iparam2stage.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,6 @@ integer iparam2stage_(integer *ispec, char *name__, char *opts, integer *ni,
}
#endif

//fprintf(stderr,"iparam2stage, subnam gross #%s#\n",subnam);

// *(unsigned char *)prec = *(unsigned char *)subnam;
strncpy(prec,subnam,1);
strncpy(algo, subnam+3,3);
Expand All @@ -347,7 +345,6 @@ integer iparam2stage_(integer *ispec, char *name__, char *opts, integer *ni,


if (*ispec == 17 || *ispec == 18) {
//fprintf(stderr,"iparam2stage spec 17/18");
/* ISPEC = 17, 18: block size KD, IB */
/* Could be also dependent from N but for now it */
/* depend only on sequential or parallel */
Expand Down Expand Up @@ -385,7 +382,6 @@ integer iparam2stage_(integer *ispec, char *name__, char *opts, integer *ni,
}

} else if (*ispec == 19) {
//fprintf(stderr,"iparam2stage spec 19\n");
/* ISPEC = 19: */
/* LHOUS length of the Houselholder representation */
/* matrix (V,T) of the second stage. should be >= 1. */
Expand All @@ -409,7 +405,6 @@ integer iparam2stage_(integer *ispec, char *name__, char *opts, integer *ni,
}

} else if (*ispec == 20) {
//fprintf(stderr,"iparam2stage spec 20\n");
/* ISPEC = 20: (21 for future use) */
/* LWORK length of the workspace for */
/* either or both stages for TRD and BRD. should be >= 1. */
Expand All @@ -424,11 +419,8 @@ integer iparam2stage_(integer *ispec, char *name__, char *opts, integer *ni,
/* + f2cmax(2*KD*KD, KD*NTHREADS) */
/* + (KD+1)*N */
lwork = -1;
char *subnam=malloc(7*sizeof(char));
strncpy(subnam,prec,1);
sprintf(subnam+1,"GEQRF");
// *(unsigned char *)subnam = *(unsigned char *)prec;
// s_copy(subnam + 1, "GEQRF", (ftnlen)5, (ftnlen)5);
strncpy(subnam,prec,1);
sprintf(subnam+1,"GEQRF");
qroptnb = ilaenv_(&c__1, subnam, " ", ni, nbi, &c_n1, &c_n1, (ftnlen)
12, (ftnlen)1);
sprintf(subnam+1,"GELQF");
Expand Down
Loading