Replace WinSparkle with app-styled in-app updater#10
Merged
Conversation
WinSparkle's stock dialog looked alien next to the Qt theme, never closed the app before running the installer (its shutdown callback was never registered), and the still-running exe stayed locked so NSIS silently kept the old binary: updates appeared to work but did not. Windows/Linux now use UpdateChecker + a themed UpdateDialog: daily background check against latest.json, in-dialog download with sha256 verification, then quit, silent NSIS install (/S), and relaunch. macOS keeps stock Sparkle. appcast-windows.xml still publishes so existing WinSparkle installs can reach this build. Also bump version to 1.0.1.
johnqherman
marked this pull request as ready for review
July 3, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.