v1.0.3: import, DCA, and stability fixes#15
Merged
Merged
Conversation
PlaybackEngine kept stale cue indices when the cue list was bulk-cleared (only cueRemoved was wired), so updateStatusBar dereferenced the null standby/current cue during Show::newShow. Reset the engine on listCleared/listLoaded, key the status bar off the bounds-checked cue pointers, and drop DCAMappingPanel's cue pointer on listCleared (it pointed into the cleared QVector).
Real .tmix files keep the cast in the profiles table (one default row per channel holding its show-setup name) and ship an empty actors table, so imports produced no actor names and the console scribble strips stayed blank. Default profile rows now fill actor names (the actors table still wins when populated), only non-default presets become voice slots, and default profile ids resolve to the Main slot in cue channel-profile references. Verified against two real show files; summary dialog and quick-start copy updated to match, and the upstream app is no longer referred to by name anywhere in the source.
The panel only repainted on cue selection change plus one guarded path from the cue editor, so inline table edits, undo/redo and paste never reached it. Route every cue-content change through CueList::cueUpdated and re-set the panel's current cue when the edited cue is the one being viewed. Also re-freshens the panel's cue pointer after list mutations.
Channel/bus assignment combos read "DCA n" plus a count only; the
cue's DCA label was visible in the overview section but not where the
assignment is actually made. Share one dcaDisplayName helper between
the overview titles and the combo item texts ("DCA 3: Hamlet (2)")
and pin a stable combo width so item text growth cannot jitter the
grid.
Reuses the File menu's import flow so a first launch can pull in an existing .tmix file without hunting through menus.
The hard 620px minimum height plus the tables' default ~192px size hint inflated both groups with empty viewport, stranding the button rows mid-dialog. Drop the height floor, size tables to their rows, and right-align the button rows to match the other list editors.
Some channels aren't tied to one person (shared mic packs), so the role is the more useful label. Adds a "Label channel with role name" checkbox in Actor Setup: when set, the console scribble strips and channel displays use the primary role, with the actor name moving to the parenthesised spot. Falls back to the actor name when no role is set; persists in the show file (older builds ignore the key).
The overview repeated the DCA name inside its member list, and each assigned channel row said the DCA number and name three times (label badge, closed combo, popup item). Overview members now drop whichever part of the channel label matches the DCA name, the [n] badge is gone (the tooltip keeps it), and closed combos paint a compact "DCA 7 (1)" while the opened menu keeps the full named items.
The app stylesheet's input padding and 18px minimum height made the in-cell editors (~30px) taller than Small/Medium rows (22/28px), so the focus border floated over neighbouring rows while typing a role into a DCA cell. Strip the box model on all four delegate editors so they fit the cell exactly.
The Actor Setup tree's role editor (default delegate) had the same overflow as the cue-table editors: the global input padding and minimum height made it taller than the row, so its focus border hung over the row below. Scope a stylesheet rule to line edits inside item views so every inline editor fits its cell, current and future.
The paste-list add flow already covers adding one actor, so the separate single Add button is gone: the row is now Add Actors..., Add Roles..., Remove. Add Roles appends deduplicated roles (commas or one per line) to every selected actor. The actor tree allows extended selection, and Remove deletes all selected actors behind one aggregate confirmation.
Branch-added comments cut to invisible-constraint one-liners, plus a repo-wide sweep of label-the-obvious comments (dialog section labels, call restaters, dangling markers). Comment-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.