v1.0.5: fix X32/M32 and WING console connections#18
Merged
Conversation
OscTransport sent requests through liblo's lo_send, which opens its own socket with its own ephemeral source port, but listened for replies on a separate QUdpSocket. X32/M32 and WING reply to the source port of each request, so every reply landed on liblo's socket and was never read. The /xinfo handshake timed out with "no response from mixer" and the client looped reconnecting against a console that was reachable the whole time. Serialise with liblo but send via the same QUdpSocket used to receive, so the request's source port is the one replies come back to. Normalise the target to IPv4 and bind AnyIPv4 to stop the ::ffff:-mapped address flip seen during reconnection. Add a regression test asserting a reply to the request's source port reaches the transport; it fails against the split-socket behaviour.
CachyOS builds Qt6 with -mno-direct-extern-access, which rides the Qt6::Platform interface target onto every translation unit. clang rejects the flag, so clangd bailed on line 1 of every file. Drop it via .clangd; the gcc build is unaffected.
The project ships under GPLv3 (see LICENSE), but CPACK_RPM_PACKAGE_LICENSE still declared MIT. Correct the packaged metadata to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.