Skip to content

Modernize Boost: update io_service to io_context and remove Boost::sy… #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonsolo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modernize Boost: update io_service to io_context and remove Boost::sy… #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ find_package(Boost REQUIRED
chrono
date_time
filesystem
program_options
system)
program_options)

if (IsWindowsPlatform)
find_package(curl REQUIRED)
Expand Down
2 changes: 1 addition & 1 deletion arras4_log/lib/arras4_athena/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ set_property(TARGET ${LibName}
)

if(IsUnixPlatform) # Linux/Darwin
set(PlatformSpecificLibs Boost::date_time Boost::system)
set(PlatformSpecificLibs Boost::date_time)
elseif(IsWindowsPlatform)
set(PlatformSpecificLibs ws2_32)
endif()
Expand Down
12 changes: 5 additions & 7 deletions arras4_log/lib/arras4_athena/UdpSyslog_boost.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <iomanip>

#include <boost/asio/buffer.hpp>
#include <boost/asio/io_service.hpp>
#include <boost/asio/io_context.hpp>
#include <boost/asio/ip/udp.hpp>
#include <boost/asio/ip/address.hpp>
#include <boost/asio/ip/host_name.hpp>
Expand Down Expand Up @@ -38,11 +38,9 @@ class UdpSyslog

// resolve hostname to target endpoint
boost::asio::ip::udp::resolver hostNameResolver(mService);
boost::asio::ip::udp::resolver::query q(boost::asio::ip::udp::v4(),
addr,
std::to_string(port),
boost::asio::ip::resolver_query_base::address_configured);
mTarget = *hostNameResolver.resolve(q);
auto results = hostNameResolver.resolve(boost::asio::ip::udp::v4(), addr, std::to_string(port));
mTarget = *results.begin();


// get local host name
boost::system::error_code err;
Expand All @@ -61,7 +59,7 @@ class UdpSyslog

private:

boost::asio::io_service mService;
boost::asio::io_context mService;
boost::asio::ip::udp::socket mSocket;
boost::asio::ip::udp::endpoint mTarget;
std::string mLocalHostName;
Expand Down