Skip to content

[com1] Add comment, fix small bug#1123

Merged
fso42 merged 1 commit into
masterfrom
RF_assess_remeshing
May 7, 2025
Merged

[com1] Add comment, fix small bug#1123
fso42 merged 1 commit into
masterfrom
RF_assess_remeshing

Conversation

@RolandFischbacher
Copy link
Copy Markdown
Contributor

@RolandFischbacher RolandFischbacher commented Apr 30, 2025

No description provided.

@RolandFischbacher RolandFischbacher linked an issue Apr 30, 2025 that may be closed by this pull request
Assess difference geoTrans.resizeData vs geoTrans.remeshData #1115
Closed
@RolandFischbacher RolandFischbacher changed the title Add documentation, fix small bug [com1] Add comment, fix small bug Apr 30, 2025
@RolandFischbacher RolandFischbacher requested a review from fso42 April 30, 2025 11:59
PaulaSp3
PaulaSp3 approved these changes Apr 30, 2025
View reviewed changes
Comment thread avaframe/in3Utils/geoTrans.py
@fso42 fso42 added the confirmed Something isn't working label May 5, 2025
@fso42 fso42 added this to the Version 1.12.1 milestone May 5, 2025
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented May 5, 2025

Code Climate has analyzed commit e65dd89 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.1%.

View more on Code Climate.

@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 5, 2025 •
edited
Loading

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: Unable to calculate total coverage change because base branch coverage was not found.

File Coverage Changes
Path File Coverage Δ Indirect
avaframe/com1DFA/deriveParameterSet.py 0.1
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

fso42
fso42 requested changes May 5, 2025
View reviewed changes
Comment thread avaframe/com1DFA/deriveParameterSet.py
@fso42
Copy link
Copy Markdown
Contributor

fso42 commented May 7, 2025

Standardtests ident

@RolandFischbacher @fso42
[doc;com1]add documentation, fix small bug
0786756 
Change logic that checks identical extend and cellsize
@fso42 fso42 force-pushed the RF_assess_remeshing branch from e65dd89 to 0786756 Compare May 7, 2025 10:43
@fso42 fso42 merged commit 092de85 into master May 7, 2025
1 of 2 checks passed
@fso42 fso42 deleted the RF_assess_remeshing branch May 7, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fso42 fso42 fso42 approved these changes

@PaulaSp3 PaulaSp3 PaulaSp3 approved these changes

Assignees

@fso42 fso42

@RolandFischbacher RolandFischbacher

Labels

confirmed Something isn't working

Projects

None yet

Milestone

Version 1.12.1

Development

Successfully merging this pull request may close these issues.

Assess difference geoTrans.resizeData vs geoTrans.remeshData

3 participants

@RolandFischbacher @fso42 @PaulaSp3