[com4FlowPy] faster backTracking, previewMode and minor improvs#1138
Merged
Conversation
ahuber-bfw
added
enhancement
ahuber-bfw
changed the title
Contributor
❌ 4 blocking issues (8 total)
@qltysh one-click actions:
|
Contributor
|
Diff Coverage: The code coverage on the diff in this pull request is 35.2%. Total Coverage: Unable to calculate total coverage change because base branch coverage was not found. File Coverage Changes
🛟 Help
|
PaulaSp3
requested changes
May 28, 2025
Contributor
PaulaSp3
left a comment
PaulaSp3
left a comment
There was a problem hiding this comment.
Very cool features! :) I have a few suggestions. IMO the code would be easier to understand when variables like 'values' and 'node' are renamed to e.g., 'infraValues' and 'parentNode'/ 'childNode'.
2 tasks
PaulaSp3
approved these changes
Jun 2, 2025
fso42
approved these changes
Jun 2, 2025
'preview-mode' prototype for sped-up version of back-tracking functionality and implementation of previewMode (previously implicitly used in back-tracking) fixed runtime Bug if infraBool=False, that was introduced with prior commit previewMode log Message added fixed minor log BUG in runCom4.. + replaces nSkipForestCells with skipForestDist [m] creation of custom WorkDir - fixed Bug with logfile if workDir doesn't exit a priori minor re-write of forestFriction part of calc_z_delta() minor code clean-up code style fixed minor log BUG in runCom4.. + replaces nSkipForestCells with skipForestDist [m] creation of custom WorkDir - fixed Bug with logfile if workDir doesn't exit a priori minor code clean-up Update docs/moduleCom4FlowPy.rst Co-authored-by: Paula Spannring <95042192+PaulaSp3@users.noreply.github.com> Update avaframe/com4FlowPy/flowClass.py Co-authored-by: Paula Spannring <95042192+PaulaSp3@users.noreply.github.com> deleted note in moduleCom4FlowPy.rst documentation finle review suggestion New implementation of back-tracking routine and indtroduction of 'preview-mode' prototype for sped-up version of back-tracking functionality and implementation of previewMode (previously implicitly used in back-tracking) fixed runtime Bug if infraBool=False, that was introduced with prior commit previewMode log Message added prototype for sped-up version of back-tracking functionality and implementation of previewMode (previously implicitly used in back-tracking) fixed runtime Bug if infraBool=False, that was introduced with prior commit previewMode log Message added added doc-strings to back-tracking functions added documentation for back-tracking in flowCore.py updated code comments in flowCore added tests, deleted deprecated backCalculation function added *.py[cod] and *.aux.xml to .gitignore updated data/avaFlowPy renamed dem in avaFlowPy updated doc and minor changes to flowCore.py changed one occurence of 'not in'
incorporated review suggestions P.S. minor change to nested funciton in calculation() removed unused imports in tests/tests_com4FlowPy
fso42
force-pushed
the
AH_com4FlowPy_backCalcNxGraph
branch
from
44c34d1 to
f36e793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main features:
A jupyter notebook on how the "back-tracking" works in principle can be found in:
https://github.com/OpenNHM/DevTestNotebooks/tree/AH_com4FlowPyBacktracking/com4FlowPyBacktracking
minor changes:
*.py[cod]and*.aux.xmlfiles)/data/avaFlowPyfixes issue #1076