[com4]: Add result file: minimum of travel length and travel angle#1159
Merged
Conversation
Contributor
PaulaSp3
commented
Jul 8, 2025
PaulaSp3
commented
Contributor
|
Diff Coverage: The code coverage on the diff in this pull request is 20.6%. Total Coverage: This PR will increase coverage by 1.1%. File Coverage Changes
🛟 Help
|
ahuber-bfw
requested changes
Jul 9, 2025
Contributor
There was a problem hiding this comment.
Thx for the PR,
- the new outputs (
travelLengthMin,fpTravelAngleMin) are producing expected results! - In release areas the use of
minwhen overlaying results from different paths leads to the effect, that (probably all) release cells will have values of0for both thetravelAngleand thetravelLengthoutput --> this has to be interpreted accordingly in the results (I tried to describe this in #1160 - since this behavior might lead to unexpected results when interpreting these outputs)
two minor change requests:
- maybe we can also initialize the
travelLenghtMaxandfpTravelAngleMaxwithnp.ones_like() * -9999- so behaviour is the same for min and max outputs - if it's easy to implement, we could only execute code parts if the respective output layers are defined in the
(local_)com4FlowPy.inifile.
Contributor
2 new issues
|
ahuber-bfw
reviewed
Jul 9, 2025
PaulaSp3
force-pushed
the
PS_FP_addOutput
branch
2 times, most recently
from
a1eb82e to
57b5738
Compare
ahuber-bfw
approved these changes
Jul 9, 2025
Contributor
ahuber-bfw
left a comment
ahuber-bfw
left a comment
There was a problem hiding this comment.
Looks good from my perspective now!
- The remaining code improvements discussed in #1161 (also using -9999 for non-affected cells in the model domain for all outputs that uses sums) can be addressed at a later stage.
fix bug fix bug doc for additional output files small adaptation null data values are 0 Revert "null data values are 0" This reverts commit aa46b4b. travelLength, fpTravelAngle, slTravelAngle, flux have value -9999 in cells that are not hit by a process Update docs/moduleCom4FlowPy.rst Co-authored-by: ahuber-bfw <112931921+ahuber-bfw@users.noreply.github.com> Update docs/moduleCom4FlowPy.rst Co-authored-by: ahuber-bfw <112931921+ahuber-bfw@users.noreply.github.com> minor minor mod to runCom4FlowPy.py to include new outputs as valid output options only comupte rasters when specified in outputs add test test calculation
PaulaSp3
force-pushed
the
PS_FP_addOutput
branch
from
981f579 to
81d5952
Compare
ahuber-bfw
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.