[com1] Rheological Models for debris-flow simulations#1169
Merged
Conversation
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
JuLa96
changed the title
awirb
requested changes
Aug 13, 2025
Contributor
awirb
left a comment
awirb
left a comment
There was a problem hiding this comment.
use citations and references in the documentation
PaulaSp3
requested changes
Aug 13, 2025
Contributor
|
Issue #1170 contains further ideas/tasks regarding rheological models. |
fso42
requested changes
Aug 14, 2025
Contributor
There was a problem hiding this comment.
General question, also @awirb : should we move the whole fricition stuff to an [FRICTION] section instead of keeping it in [GENERAL]
Furthermore: as already discussed, we should make clear that one community talks about rhological models, the other about friction types, but both mean the same thing. (in the documentation)
PaulaSp3
requested changes
Aug 19, 2025
PaulaSp3
requested changes
Sep 4, 2025
PaulaSp3
reviewed
Sep 4, 2025
PaulaSp3
requested changes
Sep 4, 2025
fso42
requested changes
Sep 8, 2025
fso42
requested changes
Sep 15, 2025
PaulaSp3
reviewed
Sep 17, 2025
PaulaSp3
requested changes
Sep 17, 2025
PaulaSp3
approved these changes
Sep 17, 2025
fso42
approved these changes
Sep 18, 2025
fso42
requested changes
Oct 13, 2025
Contributor
fso42
left a comment
fso42
left a comment
There was a problem hiding this comment.
So, 2 last points, after which I'm happy to merge this one :-)
fso42
approved these changes
Oct 14, 2025
fso42
force-pushed
the
RheologicalModels
branch
from
f18c77e to
b884ea4
Compare
Contributor
|
Standardtests ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes in:
com1DFA.com1DFACfg.ini -> input parameters
com1DFA.com1DFA.DFAIterate() -> adding new models to frictModelList
com1DFA.DFAfunctionsCython.computeForceC() -> adding new functions
com1DFA.com1DFA.createReportDict() -> adding new models to report output
theoryCom1DFA.rst -> documentation
https://docs.avaframe.org/en/rheologicalmodels/