[com1]: Assign values to returned variables in every condition#1177
Merged
Conversation
Contributor
PaulaSp3
commented
Aug 27, 2025
PaulaSp3
commented
- check if explicitFriction has valid values
- in Cython - files: check that all returned variables are assigned to a value (otherwise no error is raised, but leads to wrong results)
awirb
approved these changes
Aug 27, 2025
fso42
requested changes
Aug 28, 2025
fso42
approved these changes
Aug 28, 2025
Contributor
|
Standardtest ident |
- check if explicitFriction has valid values
fso42
force-pushed
the
PS_checkCythonFunctions
branch
from
7562081 to
e435ebc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.