Conversation
add pytest
Contributor
Analysis for project
|
| Tool | Category | Rule | Count | |
|---|---|---|---|---|
| ruff | Lint | Avoid equality comparisons to False; use if not np\.isnan\(k\): for false checks |
2 | ❌ |
| black | Style | Incorrect formatting, autoformat by running qlty fmt. |
1 | ❌ |
| ruff | Lint | Ambiguous variable name: l |
1 | ❌ |
| qlty | Structure | Function with high complexity (count = 15): createAssetsRasterFromParticleLocations | 1 | |
| qlty | Structure | Deeply nested control flow (level = 4) | 1 |
@qltysh one-click actions:
- Auto-fix formatting (
qlty fmt && git push)
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| particleAssets[indY, indX] = np.where( | ||
| particleAssets[indY, indX] >= l, particleAssets[indY, indX], l | ||
| ) | ||
|
|
Contributor
| # loop over each particle | ||
| for pId in range(len(particlesTimeArrays["ID"][0, :])): | ||
| # loop over each infrastructure class (sorted from low to high) | ||
| for l in uniqueAssets: |
Contributor
| indX = np.asarray(particlesTimeArrays["indXDEM"][0 : m + 1, pId], dtype=int) | ||
| indY = np.asarray(particlesTimeArrays["indYDEM"][0 : m + 1, pId], dtype=int) | ||
| particleAssets[indY, indX] = np.where( | ||
| particleAssets[indY, indX] >= l, particleAssets[indY, indX], l |
Contributor
| assetsValues = {} | ||
| for i in uniqueAssets: | ||
| assetsArray = np.where(assets["rasterData"] == i, cellNo, np.nan) | ||
| assetsValues["value_%d" % i] = [int(k) for k in assetsArray.flatten() if np.isnan(k) == False] |
Contributor
There was a problem hiding this comment.
| assetsValues = {} | ||
| for i in uniqueAssets: | ||
| assetsArray = np.where(assets["rasterData"] == i, cellNo, np.nan) | ||
| assetsValues["value_%d" % i] = [int(k) for k in assetsArray.flatten() if np.isnan(k) == False] |
Contributor
There was a problem hiding this comment.
Contributor
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Components (1)
Modified Files with Diff Coverage (4)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.