Skip to content

[com1]: Parallel simulation run with multiple time dep rel files #1278

Open
PaulaSp3 wants to merge 5 commits into
masterfrom
PS_timeDepRelVariation
Open

[com1]: Parallel simulation run with multiple time dep rel files #1278
PaulaSp3 wants to merge 5 commits into
masterfrom
PS_timeDepRelVariation

Conversation

@PaulaSp3
Copy link
Copy Markdown
Contributor

@PaulaSp3 PaulaSp3 commented May 20, 2026

When using the option time dependent release, for all csv files (in the REL - folder) a simualtion is done, unless a file name is not specified in the ini file.

closes: OpenNHM/DebrisFrame#64

Additionally some minor changes:

  • make the check of the time dependent release values earlier

@PaulaSp3 PaulaSp3 self-assigned this May 20, 2026
@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 20, 2026

Analysis for project AvaFrame

❌ 1 blocking issue (2 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 1
qlty Structure Deeply nested control flow (level = 4) 1

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 20, 2026

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.01%.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA63.6%

Modified Files with Diff Coverage (4)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
avaframe/in1Data/getInput.py78.8%231-233, 307, 574-576
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py100.0%
Coverage rating: D Coverage rating: D
avaframe/com1DFA/debrisFunctions.py50.0%230
Coverage rating: B Coverage rating: C
avaframe/com1DFA/deriveParameterSet.py25.0%439-441
Total75.0%
🤖 Increase coverage with AI coding...
In the `PS_timeDepRelVariation` branch, add test coverage for this new code:

- `avaframe/com1DFA/debrisFunctions.py` -- Line 230
- `avaframe/com1DFA/deriveParameterSet.py` -- Line 439-441
- `avaframe/in1Data/getInput.py` -- Lines 231-233, 307, and 574-576

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@PaulaSp3 PaulaSp3 requested review from JuLa96, awirb and fso42 and removed request for awirb and fso42 May 20, 2026 17:23
… work with scenario names instead of file paths
message = "Chosen time dependent release scenario: %s not available" % timeDepIniFileName
log.error(message)
raise FileNotFoundError(message)
else:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply nested control flow (level = 4) [qlty:nested-control-flow]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fso42: do I need to simplify this?

@PaulaSp3 PaulaSp3 requested review from awirb and fso42 May 21, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to start multiple simulations with varying csv - files (time dependent release files)

2 participants