Repository navigation
certificate: dynamically size portion length based on response buffer capacity - #8
Merged
Merged
Conversation
… capacity In DMTF SPDM conformance testing (test case 5.8 "no partial chain", assertion 5.8.4), the requester specifies Length = 0xFFFF expecting the entire remaining certificate chain to be returned in a single response when the transport and buffer allow it. Previously, generate_certificate_response unconditionally clamped portion_len to SPDM_MAX_CERT_CHAIN_PORTION_LEN (512 bytes), resulting in an unexpected non-zero RemainderLength and failing the test. Changes: - Calculate max_portion from the response buffer's remaining capacity (rsp.capacity() - headers). - Bound portion_len by min(length, remainder_len, max_portion). - Return the full remaining certificate chain when buffer capacity permits while preventing buffer overflows.
|
|
wmaroneAMD
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DMTF SPDM conformance testing (test case 5.8 "no partial chain", assertion 5.8.4), the requester specifies Length = 0xFFFF expecting the entire remaining certificate chain to be returned in a single response when the transport and buffer allow it. Previously, generate_certificate_response unconditionally clamped portion_len to SPDM_MAX_CERT_CHAIN_PORTION_LEN (512 bytes), resulting in an unexpected non-zero RemainderLength and failing the test.
Changes: