Repository navigation
measurements: validate slot_id in GET_MEASUREMENTS request - #9
Merged
Merged
Conversation
|
|
When SignatureRequested is set in GET_MEASUREMENTS, DMTF DSP0274 requires the responder to validate SlotIDParam. If the slot_id is invalid, out of range, or not provisioned (or if multi-key negotiation is enabled and the key does not support measurement signing), the responder must return an ERROR response with ErrorCode::InvalidRequest. Previously, unprovisioned slots caused sign_hash to fail internally without generating an SPDM ERROR response, causing the requester to hang indefinitely on socket read in DMTF conformance test case 7.4. Changes: - Validate that slot_id is within range and provisioned in device_certs_store. - Check that key_usage_mask supports measurement signing when multi-key negotiation is active for SPDM 1.3+. - Return ErrorCode::InvalidRequest upfront so an SPDM ERROR response is properly sent.
bluerise
force-pushed
the
spdm-valid-meas
branch
from
October 21, 2026 07:50
60125d1 to
a3dfa92
Compare
wmaroneAMD
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SignatureRequested is set in GET_MEASUREMENTS, DMTF DSP0274 requires the responder to validate SlotIDParam. If the slot_id is invalid, out of range, or not provisioned (or if multi-key negotiation is enabled and the key does not support measurement signing), the responder must return an ERROR response with ErrorCode::InvalidRequest. Previously, unprovisioned slots caused sign_hash to fail internally without generating an SPDM ERROR response, causing the requester to hang indefinitely on socket read in DMTF conformance test case 7.4.
Changes: