Avoid per-node numeric type tuples in compact decoding - #980
Draft
bradhilton wants to merge 1 commit into
Draft
bradhilton wants to merge 1 commit into
bradhilton wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compact decoding rebuilds a
(bool, int, float)tuple at every JSON node. Replace it with directintandfloatchecks;boolremains covered byint. Container reconstruction, string references, validation errors and independent mutable results are unchanged.Validation: 50 focused tests pass (23 new scalar/ownership/error cases plus the existing compact serialization suite), Ruff/format and scoped type checks pass, and
uv lock --check --offlinepasses. An independently reviewed public fixture also passed 22 control groups, including the actual compressed Caladan dataset stream's order, slices, repeated/interleaved iteration and identity.Public CPU benchmarks on CPython 3.12.13 used 13 randomized paired rounds. With cyclic GC outside the timed sections, compact validation was 14.3% faster and an eight-row compressed stream was 12.3% faster. The initial natural-GC measurements were noisy and showed only about 3% median gains. These are local synthetic measurements, not production latency or GPU-utilization claims. The fixtures use public ChatCompletion objects; no private inputs or GPU workload.
This draft is separate from the tokenizer and checkpoint-copy changes. It adds no cache, decoder API, offload or iteration change.