Preserve GPU image smoke and downstream dispatch - #993
Merged
Merged
Conversation
bradhilton
changed the title
bradhilton
marked this pull request as ready for review
September 26, 2026 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A superseding
mainpush can currently cancel the GPU image workflow after its image has been pushed but while all-cluster prewarm is still running. The cancelled run then skips its smoke and Caladan dispatch; run 36260772556 did exactly that after pushing its digest.Keep the active workflow running through prewarm, smoke, and dispatch. GitHub concurrency still permits only one active run and one replaceable pending run, so this serializes the mutable
latestpipeline without an unbounded queue of intermediate revisions. The guarantee ends at Caladan dispatch submission; Caladan's existing image/source check still fails closed iflatestno longer matches the dispatched ART revision.Validation:
yq eval '.' .github/workflows/build-gpu-image.ymluv run pytest -q tests/unit/test_gpu_image_build_context.py(2 passed)Preparing this PR performed no build, dispatch, prewarm, or deployment. Merging to
mainretains the existing automatic pipeline trigger and intentionally lets its resource-bearing workflow finish instead of canceling it on a later push.