Keep Tau error cleanup within its original deadline on cancellation - #994
Merged
Merged
Conversation
bradhilton
marked this pull request as ready for review
September 26, 2026 20:53
bradhilton
marked this pull request as draft
September 26, 2026 21:02
bradhilton
marked this pull request as ready for review
September 26, 2026 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second parent cancellation could abandon an environment deletion already cleaning up an earlier rollout failure. Continue waiting for cooperative deletion within the original absolute 30-second deadline, then preserve the primary error and later cancellation together. Repeated cancellation does not renew the deadline.
The existing deadline fallback is retained: an unfinished deletion is cancelled and its result consumed by the existing callback. This does not promise completion of cancellation-resistant deletion or change success-path deletion.
Validation: all 39 Tau client tests pass. Five new cases fail on the prior source and cover ordinary/cancellation primary errors, repeated cancellation, cleanup failure, and the decreasing timeout budget. Existing deadline and resistant-delete tests remain unchanged. Ruff, formatting and affected type checks pass; independent source review is clear. Fake client only, with no provider calls or live-source changes.
Downstream validation: nine offline actual-method controls cover maintained Caladan and the pending evaluation helper in OpenPipe/caladan#844. Ordinary induced cancellation remains an isolated incomplete evaluation; a mixed body error and later cancellation preserves the prior fatal outcome while completing DELETE. No dependency on the separate dynamics cleanup PR was established. Frozen experiment snapshots require their own adoption review.