docs(guides): require CLUSTER_JOIN_PROOF in the HA clustering join steps

[claude]

Requested by Alex · project thread

Before: the "Join additional nodes" section of the HA clustering guide told operators to start a second node with only CLUSTER_ENABLED, CLUSTER_NODE_ID, CLUSTER_JOIN, CLUSTER_SECRET and LRTMP2_DB. Anyone following those steps against a current server gets the join refused, because the server has required an admin-minted join proof for a fresh join since librtmp2-server commit 0109d98 (12 August). The endpoint table on the same page also had no row for the endpoint that mints the proof, so there was nothing on the page pointing at the missing piece.

After: the section first mints a one-time proof on an existing member via POST /api/v1/cluster/join-proof, then starts the joiner with CLUSTER_JOIN_PROOF set, and the endpoint table lists POST /api/v1/cluster/join-proof. Following the page end to end now produces a node that actually joins.

The join snippet also gained CLUSTER_BIND, CLUSTER_MEDIA_BIND, CLUSTER_ADVERTISE_ADDR and CLUSTER_MEDIA_ADVERTISE_ADDR. That is not decoration: the proof is bound to the node ID and to the advertised control and media addresses, and with no advertise addresses set the joiner falls back to rewriting its wildcard bind to loopback (ClusterConfig::advertise_control / advertise_media in src/cluster/config.rs), which cannot match a proof minted for a routable address. Without those four lines the snippet would still fail.

How: edits are confined to guides/rtmp-server-ha-clustering/index.php — two new paragraphs and a curl block in the join section, four added lines in the joiner env block, a note that the proof is single-purpose and address-bound while an existing member restarting on the resume path needs no new proof, the reseed sentence now mentioning a fresh proof, and one new table row. Wording and the request/response shape follow docs/clustering.md in librtmp2-server, which is the canonical reference the page already links to. No shared includes, styles or other pages touched; php -l is clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HyaN2Pdss6XpJ2MWgxfhy5

---

Generated by Claude Code

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 51a8ee84-7ea9-447b-8d74-d9fcb803b76c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud