Nhse o34 upstream.d34 erlfmt #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add block types, so that based on the content of blocks, a block can be split into different arrangements of sub-blocks. This will allow for head/tail of the block with index entries to be exposed, to allow for more efficient 2i. Also in general, when looking for the nth element, only a sub-block will need to be opened. The code trades performance for neatness, with precise pattern matching used to avoid overheads with copying when concatenating lists.
Add extended query support: - Query terms can be split into a map of projected attributes using an evaluation expression - Terms can be filtered based on the map of projected attributes using a filter expression - Query results cna be combined using a set expression Co-authored-by: Thomas Arts <thomas.arts@quviq.com>
* Standardise formatting using erlfmt Adding check of format to github actions * Exclude generated files from formatting * Use correct filelib function Previously checked a file and also not a directory - where is_regular/1 is specifically checking the same thing. Avoids a coverage miss, now the line has been reformated (as in our tests it is always a file), the only variance is when it is a directory. * Revise formatting Exclude where formatting has created less readable code (e.g. leveled_sstblock). Also where erlfmt splits across lines and isolates the fun keyworrd in a fun((_) -> _) definition - this can cause problems with some editors/linters. * Resolve highlighting issue by removing parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring up-to-date with upstream changes