chore: 🐝 Update SDK - Generate SDK 0.5.0#163
Conversation
mattapperson
force-pushed
the
speakeasy-sdk-regen-1776877485
branch
7 times, most recently
from
f7fda73 to
132f840
Compare
mattapperson
force-pushed
the
speakeasy-sdk-regen-1776877485
branch
14 times, most recently
from
a9d26b0 to
7064f71
Compare
mattapperson
force-pushed
the
speakeasy-sdk-regen-1776877485
branch
8 times, most recently
from
0318849 to
4030c20
Compare
mattapperson
force-pushed
the
speakeasy-sdk-regen-1776877485
branch
4 times, most recently
from
040e86b to
450bd26
Compare
![perry-the-pr-reviewer[bot]](https://avatars.githubusercontent.com/in/3222961?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Perry's Review
SDK 0.4.2 regeneration via Speakeasy — adds BYOK, Observability, Presets, STT, and Datasets endpoints, plus breaking changes across Chat, Responses, VideoGeneration, and Guardrails.
Verdict: 🔁 Needs changes
Details
CI: no checks configured ✅
Findings (see inline comments for full context):
- 🟡
byok.go:242— paginationNext()never terminates whenlimitis nil - 🟡
observability.go:241— same pagination bug as above - 🟡
docs/sdks/chat/README.md:58—res.ChatStreamingResponsefield doesn't exist; should beres.EventStream - nit:
README.md:351already has an open Perry thread for the sameChatStreamingResponseissue — skipped to avoid duplicate
Codex (openai/gpt-5.5): timed out at 60s (still reading files) — no additional findings merged
Research: Speakeasy pagination docs confirm: when limit input is omitted, Next() must return nil on empty array only (len(arr) == 0), not on len(arr) < 0. The if len(arr) < l check is the correct termination when l > 0; the nil-limit branch is missing entirely.
Security: no concerns — no secrets, no auth changes, standard BYOK key routing through existing PopulateSecurity() pattern
Test coverage: no tests cover the new BYOK, Observability, or pagination endpoints; this is the existing pattern for Speakeasy-generated SDKs
Unresolved threads: 1 existing open Perry thread on README.md:351 (same ChatStreamingResponse field issue — deduped this review)
Scope: first review (full)
Tier: large (65757 LoC)
| if limit != nil { | ||
| l = int(*limit) | ||
| } | ||
| if len(arr) < l { |
There was a problem hiding this comment.
[suggestion] pagination Next() never terminates when limit is nil — len(arr) < 0 is always false
| if len(arr) < l { | |
| if len(arr) == 0 || (l > 0 && len(arr) < l) { |
Details
Why: When limit is nil, l = 0, making len(arr) < 0 always false for any non-negative count. Per Speakeasy pagination docs, when no limit is configured the termination condition is len(arr) == 0 (empty page signals last page). The current code will loop infinitely as long as the API returns any results, recursively calling s.List() until the goroutine stack exhausts.
Fix: Change if len(arr) < l to if len(arr) == 0 || (l > 0 && len(arr) < l). The same fix is needed in observability.go at the equivalent line.
Prompt for agents
In `byok.go` line 242, the pagination termination check `if len(arr) < l` is buggy when `limit` is nil. When `limit` is nil, `l` is 0 so `len(arr) < 0` is always false — `Next()` recurses indefinitely on any non-empty page. Fix: change `if len(arr) < l {` to `if len(arr) == 0 || (l > 0 && len(arr) < l) {`. Apply the identical fix at `observability.go` line ~241.
Reviewed at 2893036
| if limit != nil { | ||
| l = int(*limit) | ||
| } | ||
| if len(arr) < l { |
There was a problem hiding this comment.
[suggestion] same pagination termination bug as byok.go:242 — len(arr) < l never fires when limit is nil
| if len(arr) < l { | |
| if len(arr) == 0 || (l > 0 && len(arr) < l) { |
Details
Identical to the byok.go issue: l = 0 when limit is nil, so len(arr) < 0 is never true.
Reviewed at 2893036
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| if res != nil { | ||
| defer res.Object.Close() | ||
| defer res.ChatStreamingResponse.Close() |
There was a problem hiding this comment.
[suggestion] res.ChatStreamingResponse — field does not exist on *operations.SendChatCompletionRequestResponse; correct field is res.EventStream
| defer res.ChatStreamingResponse.Close() | |
| defer res.EventStream.Close() |
Details
Why: SendChatCompletionRequestResponse is a union type with field EventStream *stream.EventStream[components.ChatStreamingResponse]. ChatStreamingResponse is the type parameter of the generic, not the field name. Accessing res.ChatStreamingResponse will fail to compile with res.ChatStreamingResponse undefined.
Lines 60–61 need the same fix: res.ChatStreamingResponse.Next() → res.EventStream.Next() and res.ChatStreamingResponse.Value() → res.EventStream.Value().
The same issue affects README.md:351–354 (open Perry thread) and docs/sdks/chat/README.md:113–116.
Fix: Replace all three occurrences in this file and the three in README.md.
Prompt for agents
In `docs/sdks/chat/README.md` lines 58, 60, 61, 113, 115, 116 and in `README.md` lines 351, 353, 354, replace every occurrence of `res.ChatStreamingResponse` with `res.EventStream`. The struct `SendChatCompletionRequestResponse` has a field named `EventStream` (of type `*stream.EventStream[components.ChatStreamingResponse]`) — `ChatStreamingResponse` is only the generic type parameter, not the field name. The code currently won't compile.
Reviewed at 2893036
There was a problem hiding this comment.
Perry's Review
SDK 0.4.2 regeneration via Speakeasy — adds BYOK, Observability, Presets, Datasets, STT endpoints, and brings new server-tool types (AdvisorServerTool, WebFetch), plus breaking changes across Chat, Responses, and core model types.
Verdict: 🔁 Needs changes
Details
CI: no checks configured ✅
Findings (see inline comments for full context):
- 🔴
chat.go:37—Chat.Sendadds new requiredxOpenRouterExperimentalMetadataparameter, breaking all existing callers - 🔴
responses.go:38—Responses.Sendsame new required parameter, breaking all existing callers - 🔴
models/components/chatrequest.go:338—Reasoningtype renamed toChatRequestReasoning;Effortrenamed toChatRequestEffort— breaking type change without compatibility aliases - 🟡
README.md:351—res.ChatStreamingResponsefield doesn't exist (open prior Perry thread) — still unresolved; see existing inline comment - 🟡
docs/sdks/chat/README.md:58— sameres.ChatStreamingResponsebug in generated SDK docs (open prior Perry thread) — still unresolved
Codex (openai/gpt-5.5): 5 findings — confirmed 3 new blockers (Chat.Send/Responses.Send breaking params, Reasoning type rename); 2 server-tool type constructor gaps are pre-existing Speakeasy pattern (not new in this PR)
Research: Speakeasy marks 8 operations as "Breaking res.ChatStreamingResponse) is a Speakeasy codegen docs issue that persists across this regeneration.
Security: no concerns — BYOK credential handling follows existing PopulateSecurity() pattern, no new auth paths introduced
Test coverage: no tests cover new BYOK, Observability, Presets, Datasets, or STT endpoints — consistent with the existing no-tests pattern for Speakeasy-generated SDKs
Unresolved threads: 4 from prior review — 2 on README streaming (still unresolved in current code), 2 on pagination (code is correct: len(arr)==0 check present; prior finding was incorrect)
Scope: first review (full)
Tier: large (65782 LoC)
| // Send - Create a chat completion | ||
| // Sends a request for a model response for the given chat conversation. Supports both streaming and non-streaming modes. | ||
| func (s *Chat) Send(ctx context.Context, request components.ChatRequest, opts ...operations.Option) (*operations.SendChatCompletionRequestResponse, error) { | ||
| func (s *Chat) Send(ctx context.Context, chatRequest components.ChatRequest, xOpenRouterExperimentalMetadata *components.MetadataLevel, opts ...operations.Option) (*operations.SendChatCompletionRequestResponse, error) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -35,7 +35,12 @@ func newResponses(rootSDK *OpenRouter, sdkConfig config.SDKConfiguration, hooks | |||
|
|
|||
| // Send - Create a response | |||
| // Creates a streaming or non-streaming response using OpenResponses API format | |||
| func (s *Responses) Send(ctx context.Context, request components.ResponsesRequest, opts ...operations.Option) (*operations.CreateResponsesResponse, error) { | |||
| func (s *Responses) Send(ctx context.Context, responsesRequest components.ResponsesRequest, xOpenRouterExperimentalMetadata *components.MetadataLevel, opts ...operations.Option) (*operations.CreateResponsesResponse, error) { | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| // Reasoning - Configuration options for reasoning models | ||
| type Reasoning struct { | ||
| // ChatRequestReasoning - Configuration options for reasoning models | ||
| type ChatRequestReasoning struct { |
There was a problem hiding this comment.
[blocker] Reasoning type renamed to ChatRequestReasoning; Effort renamed to ChatRequestEffort — breaking type change without compatibility aliases
Details
Why: Two types were renamed:
components.Reasoning→components.ChatRequestReasoningcomponents.Effort(and its constantsEffortHigh,EffortMedium,EffortLow) →components.ChatRequestEffort(with constantsChatRequestEffortHigh,ChatRequestEffortMedium,ChatRequestEffortLow)
Any caller that uses components.Reasoning{}, components.EffortHigh, etc. will fail to compile. No type alias or compatibility shim was generated.
Fix for callers:
// Before
chatRequest.Reasoning = &components.Reasoning{
Effort: optionalnullable.From(components.EffortHigh),
}
// After
chatRequest.Reasoning = &components.ChatRequestReasoning{
Effort: optionalnullable.From(components.ChatRequestEffortHigh),
}Ref: PR description — ChatRequest.Reasoning field Changed (Breaking
Prompt for agents
In `models/components/chatrequest.go`, two types were renamed as part of the SDK regeneration: `Reasoning` → `ChatRequestReasoning` (line 338) and `Effort` → `ChatRequestEffort` (line 311), along with all associated constants (`EffortHigh` → `ChatRequestEffortHigh`, etc.). Any caller that references `components.Reasoning`, `components.Effort`, `components.EffortHigh`, `components.EffortMedium`, or `components.EffortLow` must be updated to use the new names. Search for these old names and replace with the new ones.
Reviewed at bf5fcad
There was a problem hiding this comment.
Perry's Review
Speakeasy-generated Go SDK bump to v0.4.2 — adds BYOK, Observability, Presets, STT endpoints, new model components, and threading OpenRouterMetadata through openrouter_metadata response fields.
Verdict: 🔁 Needs changes
Details
CI: no checks registered ✅
Findings (see inline comments for full context):
Previously raised blockers (7 unresolved threads — code unchanged):
- 🔴
chat.go:37—Chat.Sendnew requiredxOpenRouterExperimentalMetadataparameter breaks all existing callers - 🔴
responses.go:38—Responses.Sendsame breaking required parameter - 🔴
models/components/chatrequest.go:338—Reasoningtype renamed toChatRequestReasoning;Effortrenamed toChatRequestEffort— compile break for existing callers - 🟡
README.md:351— example uses non-existentres.ChatStreamingResponsefield (correct:res.EventStream) - 🟡
byok.go:242— paginationNext()never terminates whenlimitis nil - 🟡
observability.go:241— same pagination termination bug
New finding this review:
- 🟡
byok.go:88/observability.go:87—defer cancel()fires whenList()returns, leaving thectxcaptured byNext()closure already cancelled; pagination with a configured timeout fails on the second page withcontext.Canceled
Codex (openai/gpt-5.5): independently flagged the ctx-cancellation bug in byok.go and observability.go (finding confirmed)
Research: Go module semantic versioning — adding required parameters to exported function signatures is a breaking change. At v0.x, SemVer allows breaking changes, but existing go get users are not shielded. The pointer parameter *MetadataLevel already makes this optional at the Go type level, so the breaking change is specifically the new required positional argument in the call site.
Security: no concerns — no credential patterns in diff; openrouter_metadata is routing metadata only
Test coverage: no new tests for new endpoints (STT, BYOK, Observability, Presets, Datasets); pagination logic is hand-editable despite generated status
Unresolved threads: 7 — all from prior Perry review, none addressed
Scope: first review (full) · Tier: large (65795 LoC)
| if timeout != nil { | ||
| var cancel context.CancelFunc | ||
| ctx, cancel = context.WithTimeout(ctx, *timeout) | ||
| defer cancel() |
There was a problem hiding this comment.
[suggestion][codex] defer cancel() fires when List returns, cancelling the ctx captured by the Next() closure — pagination with a timeout configured fails with context.Canceled on the second page
Details
Why: At line 87 ctx is reassigned to a timeout-derived context, and defer cancel() at line 88 is scheduled to fire when List returns. The res.Next closure (line 208) captures this shadowed ctx. By the time a caller invokes res.Next(), List() has returned, the defer has fired, and the captured context is already cancelled. The recursive s.List(ctx, ...) inside Next() immediately returns context.Canceled.
Fix: Capture the original context before the timeout branch and pass it to the recursive call:
origCtx := ctx // capture before timeout wrapping
if timeout != nil {
ctx, cancel = context.WithTimeout(ctx, *timeout)
defer cancel()
}
// ... inside res.Next closure:
return s.List(origCtx, ...)Ref: Go context blog — contexts should be passed explicitly, not captured from an outer scope that owns the cancellation.
Prompt for agents
In byok.go the res.Next closure (line 208) captures ctx, which was shadowed at line 87 by context.WithTimeout and cancelled by defer cancel() at line 88 when List() returns. The same pattern exists in observability.go at lines 86/207. Fix: add origCtx := ctx immediately before the timeout branch in both files, then change the recursive s.List(ctx, ...) call inside each res.Next closure to s.List(origCtx, ...). This allows pagination to succeed even when the SDK is configured with a per-call timeout.
Reviewed at 5ba2e1c
There was a problem hiding this comment.
Perry's Review
Speakeasy-generated Go SDK bump to v0.4.2 — adds BYOK, Observability, Presets, STT endpoints and new model components. This is a force-push with the same content as the prior reviewed commit; all 8 unresolved findings from previous reviews remain unaddressed.
Verdict: 🔁 Needs changes
Details
CI: no checks registered ✅
Findings: All findings previously raised as inline review comments — 3 blockers and 5 suggestions — remain unresolved. See the existing inline review threads on this PR for full details.
Blockers:
- Breaking
Chat.Sendsignature change (new requiredxOpenRouterMetadataparameter, all callers compile-break) - Breaking
Responses.Sendsignature change (same) - Type rename:
Reasoning→ChatRequestReasoning,Effort→ChatRequestEffort(compile break for existing callers)
Suggestions:
- README and docs examples reference non-existent
res.ChatStreamingResponsefield (should beres.EventStream) byok.goandobservability.gopaginationNext()infinite loop whenlimitis nildefer cancel()inList()fires beforeNext()can run — timeout-configured pagination fails withcontext.Canceledon second page
Codex (openai/gpt-5.5): confirmed the defer cancel() pagination context cancellation bug; also surfaced the same pre-existing pattern in streaming endpoints
Research: Go semver at v0.x permits breaking signature changes but all existing callers require a nil argument addition at every invocation. No migration shim provided.
Security: no concerns — no credential patterns; openrouter_metadata is routing metadata only
Test coverage: no tests for any new endpoints (STT, BYOK, Observability, Presets, Datasets)
Unresolved threads: 8 — all from prior Perry reviews, none addressed in this push
Scope: incremental — 0 new lines since prior review (force-push, same content) · Tier: large (67738 LoC)
There was a problem hiding this comment.
Perry's Review
Speakeasy-regenerated SDK update (v0.4.1→0.4.2) adding 5 new endpoint groups (BYOK, Datasets, Observability, Presets, STT), new plugins (Fusion, WebFetch), ForbiddenResponseError (403) handling, and OpenrouterMetadata field on all error types. The PR flags multiple breaking API changes.
Verdict: 🔁 Needs changes
Details
CI: no checks configured
Findings (see inline comments for full context):
- 🔴
models/components/chatrequest.go:311—Effort→ChatRequestEffortandReasoning→ChatRequestReasoningtype renames break existing callers - 🟡
byok.go:87— paginationNext()closure captures cancelled context; fails withcontext.Canceledwhen timeout is configured - 🟡
README.md:351—res.ChatStreamingResponsefield doesn't exist; correct field isres.EventStream - 🟡 Version bump 0.4.1→0.4.2 (patch) contains breaking API changes; semver convention for pre-v1 modules recommends minor bump (0.5.0) for breaking changes
Codex (openai/gpt-5.5): confirmed context cancellation bug in byok.go and observability.go; flagged Accept header q=0 for SSE (pre-existing pattern, not new in this PR)
Research: Speakeasy's automatic versioning bumps on document checksum only — does not analyze semantic breakage. Community convention: breaking changes in pre-v1 warrant a minor bump, not patch. (semver.org, Speakeasy versioning docs)
Security: BYOK endpoints don't expose raw key values (encrypted at rest per API docs). Category 1 (provider API key handling) TOUCHED but safeguard intact. No secrets found in diff. No concerns.
Test coverage: 2 test files in repo. No coverage for 5 new endpoint groups or pagination/context bugs. Pre-existing gap.
Unresolved threads: 6 active prior Perry threads (type renames, context cancellation, README field name, pagination termination) all remain unaddressed at current HEAD.
| // Effort - Constrains effort on reasoning for reasoning models | ||
| type Effort string | ||
| // ChatRequestEffort - Constrains effort on reasoning for reasoning models | ||
| type ChatRequestEffort string |
There was a problem hiding this comment.
[blocker] Effort renamed to ChatRequestEffort — all callers referencing components.Effort, components.EffortHigh, components.EffortMedium, etc. will fail to compile
Details
Why: The type Effort and all its constants (EffortXhigh, EffortHigh, EffortMedium, EffortLow, EffortMinimal, EffortNone) have been renamed to ChatRequestEffort / ChatRequestEffortXhigh, etc. The companion struct Reasoning was also renamed to ChatRequestReasoning (line 338). No type aliases or compatibility shims were generated, so any existing code using these types will not compile against v0.4.2.
Fix:
// Before v0.4.2
chatRequest.Reasoning = &components.Reasoning{
Effort: optionalnullable.From(components.EffortHigh),
}
// After v0.4.2
chatRequest.Reasoning = &components.ChatRequestReasoning{
Effort: optionalnullable.From(components.ChatRequestEffortHigh),
}Ref: PR description — ChatRequest.Reasoning field Changed (Breaking
Prompt for agents
In `models/components/chatrequest.go`, the types `Effort` and `Reasoning` were renamed to `ChatRequestEffort` and `ChatRequestReasoning`. All callers using the old names will fail to compile. Add type aliases for backward compatibility: `type Effort = ChatRequestEffort` and `type Reasoning = ChatRequestReasoning`, plus constant aliases for all `Effort*` constants. Alternatively, bump the version to 0.5.0 to signal a minor breaking change per semver convention.
Reviewed at d23a8c4
|
|
||
| if timeout != nil { | ||
| var cancel context.CancelFunc | ||
| ctx, cancel = context.WithTimeout(ctx, *timeout) |
There was a problem hiding this comment.
[suggestion] defer cancel() fires when List() returns, cancelling the ctx captured by the Next() closure — calling res.Next() with a timeout configured fails with context.Canceled
Details
Why: At line 87 ctx is reassigned to a timeout-derived context. defer cancel() at line 88 fires when List() returns. The res.Next closure (line 209) captures this shadowed ctx. By the time a caller invokes res.Next(), the cancel has already been called, so stream.EventStream.Next() immediately returns false with context.Canceled. The same bug exists in observability.go at the equivalent lines.
Fix: Save the original context before the timeout branch and use it in the recursive call:
origCtx := ctx // capture before timeout wrapping
if timeout != nil {
var cancel context.CancelFunc
ctx, cancel = context.WithTimeout(ctx, *timeout)
defer cancel()
}
// ... inside res.Next closure:
return s.List(origCtx, ...)Ref: Go context docs
Prompt for agents
In `byok.go` line 87, add `origCtx := ctx` immediately before the timeout branch (before `if timeout != nil`). In the `res.Next` closure at line 248, change the recursive `s.List(ctx, ...)` call to `s.List(origCtx, ...)`. Apply the identical fix in `observability.go` at the equivalent lines (~85 and ~246). This ensures pagination calls get a fresh, non-cancelled context even when the initial `List()` call was configured with a per-request timeout.
Reviewed at d23a8c4
| } | ||
| if res != nil { | ||
| defer res.Object.Close() | ||
| defer res.ChatStreamingResponse.Close() |
There was a problem hiding this comment.
[suggestion] res.ChatStreamingResponse — field does not exist on *operations.SendChatCompletionRequestResponse; correct field is res.EventStream
| defer res.ChatStreamingResponse.Close() | |
| defer res.EventStream.Close() |
Details
The struct SendChatCompletionRequestResponse has two fields: ChatResult *components.ChatResult and EventStream *stream.EventStream[components.ChatStreamingResponse]. The README uses res.ChatStreamingResponse at lines 351–354, but no such field or method exists — these examples will fail to compile. The same issue appears in docs/sdks/chat/README.md at lines 58–61 and 113–116.
Fix: Replace all occurrences of res.ChatStreamingResponse with res.EventStream across README.md and docs/sdks/chat/README.md.
Reviewed at d23a8c4
There was a problem hiding this comment.
Perry's Review
Speakeasy-generated SDK bump to v0.4.2 — adds BYOK, Datasets, Observability, Presets, and STT endpoint groups; adds Fusion streaming events; adds ForbiddenResponseError (403) handling and OpenrouterMetadata field on all error types.
Verdict: 🔁 Needs changes
Details
CI: no checks configured
Findings (see inline comments for full context):
- 🔴
chat.go:79—defer cancel()cancels the streaming context before the caller reads the EventStream - 🔴
responses.go:80— samedefer cancel()streaming context bug - 🔴
docs/sdks/responses/README.md:41—res.ResponsesStreamingResponsefield doesn't exist; correct field isres.EventStream - nit: version 0.4.2 contains multiple breaking API changes; pre-v1 semver convention suggests a minor bump (0.5.0)
Still open (unresolved threads from prior reviews):
Reasoning→ChatRequestReasoningandEffort→ChatRequestEfforttype renames break callersres.ChatStreamingResponsefield doesn't exist in README examplesdefer cancel()in pagination closures inbyok.goandobservability.go
Note: The pagination len(arr) < l finding in prior Perry threads is a false positive per Speakeasy pagination docs — when limit is omitted, termination on empty page only is intentional.
Codex (openai/gpt-5.5): confirmed defer cancel() streaming context bug; identical issue in pagination closures (already in prior threads)
Research: Go context docs — defer cancel() fires on function return; storing that context in a returned EventStream violates Go's context lifecycle. Fix: attach cancel to EventStream.Close().
Security: BYOK credential management handled correctly. Category 1 (provider API key handling) TOUCHED; ForbiddenResponseError (Category 7) added correctly. No secrets in diff.
Test coverage: no tests added for 5 new endpoint groups. Pre-existing gap.
Unresolved threads: 9 open from prior reviews; 2 are outdated; 7 remain active.
Scope: incremental — 1154 new lines since prior review
Tier: large (68764 LoC)
| bodyReader, reqContentType, err := utils.SerializeRequestBody(ctx, request, false, false, "ChatRequest", "json", `request:"mediaType=application/json"`) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
[blocker] defer cancel() cancels the streaming context before the caller can read the EventStream — any configured SDK or operation timeout silently breaks streaming
Details
Why: context.WithTimeout creates a child context; defer cancel() fires the moment Chat.Send() returns. The EventStream created downstream captures ctx internally. When the caller subsequently calls res.EventStream.Next(), it immediately sees ctx.Done() fired and returns false with context.Canceled — the timeout has already elapsed from the perspective of the stream, even if the actual timeout duration has not passed.
This affects all users who set an SDK-level timeout (openrouter.WithTimeout(...)) or per-call timeout (operations.WithTimeout(...)) AND use streaming. Non-streaming callers are unaffected since the full response body is read before the function returns.
Fix: Move ownership of cancel into the returned EventStream so it fires when Close() is called, not when Send() returns. If stream.NewEventStream supports a callback option, pass cancel there. Otherwise, add a WithClose functional option to EventStream and call cancel inside Close().
Ref: Go context docs — contexts should not be stored in structs
Prompt for agents
In `chat.go` around line 87-91 (the `context.WithTimeout` + `defer cancel()` block), the deferred cancel fires when `Chat.Send()` returns — before the caller can read the returned EventStream. The EventStream captures `ctx` internally and checks `ctx.Done()` in `Next()`. Fix: remove `defer cancel()` and instead pass `cancel` to the EventStream so it is called in `EventStream.Close()`. If `stream.NewEventStream` does not accept a close callback, add one (e.g. `stream.WithClose(cancel)` functional option in `types/stream/stream.go`). Apply the identical fix in `responses.go` at the equivalent `defer cancel()` block.
Reviewed at 0e82f46
| @@ -69,7 +74,7 @@ func (s *Responses) Send(ctx context.Context, request components.ResponsesReques | |||
| OAuth2Scopes: nil, | |||
| SecuritySource: s.sdkConfiguration.Security, | |||
| } | |||
| bodyReader, reqContentType, err := utils.SerializeRequestBody(ctx, request, false, false, "Request", "json", `request:"mediaType=application/json"`) | |||
| bodyReader, reqContentType, err := utils.SerializeRequestBody(ctx, request, false, false, "ResponsesRequest", "json", `request:"mediaType=application/json"`) | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
There was a problem hiding this comment.
[blocker] defer cancel() — same streaming context cancellation bug as chat.go — EventStream.Next() immediately fails with context.Canceled when a timeout is configured
Details
Why: Same root cause as chat.go: defer cancel() fires when Responses.Send() returns, cancelling the context captured by the EventStream. Any SDK or per-call timeout configured by the caller breaks streaming responses.
Fix: Same as chat.go — move cancel ownership into the EventStream.Close() path.
Prompt for agents
In `responses.go` around line 88-90, `defer cancel()` fires when `Responses.Send()` returns, cancelling the context captured by the returned EventStream. Calling `res.EventStream.Next()` immediately fails with `context.Canceled` when a timeout is configured. Fix: remove `defer cancel()` and pass `cancel` to `stream.NewEventStream` so it fires in `Close()` instead. The identical fix is needed in `chat.go`.
Reviewed at 0e82f46
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| if res != nil { | ||
| defer res.Object.Close() | ||
| defer res.ResponsesStreamingResponse.Close() |
There was a problem hiding this comment.
[suggestion] res.ResponsesStreamingResponse field does not exist on *operations.CreateResponsesResponse — this example will not compile
| defer res.ResponsesStreamingResponse.Close() | |
| defer res.EventStream.Close() |
Details
CreateResponsesResponse has field EventStream *stream.EventStream[components.ResponsesStreamingResponse]. ResponsesStreamingResponse is the generic type parameter, not the field name. Lines 43-44 and lines 77-80 need the same fix.
Ref: models/operations/createresponses.go:20
Reviewed at 0e82f46
There was a problem hiding this comment.
Perry's Review
Auto-generated Go SDK update (v0.4.1 → v0.4.2) adding BYOK, Datasets, Observability, Presets, and STT endpoints plus Fusion and WebFetch plugins. All 14 unresolved findings from the prior review remain open and unaddressed in this push.
Verdict: 🔁 Needs changes
Details
CI: no CI configured for this repo
Open findings (carry-forward — see prior inline comments):
- 2 blockers: type renames (
Effort → ChatRequestEffort,Reasoning → ChatRequestReasoning) without semver minor bump;defer cancel()cancels streaming context before caller reads EventStream - 3 suggestions: pagination termination bug when
limitis nil (byok.go, observability.go);res.ChatStreamingResponsefield name wrong in README (should beres.EventStream) - All findings are already in active unresolved Perry review threads — no new inline comments added to avoid duplication
Codex (openai/gpt-5.5): 2 findings surfaced — pagination context capture in byok/observability Next(); POST retry without idempotency key on BYOK/Observability Create (pre-existing SDK pattern, not new)
Research: Speakeasy breaking-changes guide confirms 0.5.0 is the correct version for exported type renames in a pre-v1 SDK. Context cancellation on EventStream return is a Go idiom violation with no upstream Speakeasy tracking.
Security: no concerns — auth plumbing unchanged, no credential logging
Test coverage: no SDK-level tests; doc examples non-compilable (res.ChatStreamingResponse field name)
Unresolved threads: 14 open Perry threads from prior review, all still unresolved
Scope: incremental — 58 new lines since prior review (1 new doc file: docs/models/components/dataregion.md)
Tier: large (68808 LoC)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Perry's Review
Speakeasy regeneration bumping the Go SDK 0.4.1 → 0.4.2: adds BYOK, Datasets (app-rankings/daily-rankings), Observability, Presets, beta-analytics & STT endpoints, a new 403 Forbidden response path, and several breaking request/response signature changes.
Verdict: 🔁 Needs changes
Details
CI: no checks configured/run on this commit (combined status empty) — not a gate on this verdict.
State of prior review: Perry's last review (12cc087) requested changes and 17 threads remain unresolved. This push (the delta 12cc087..b2f3e1d) adds the Datasets service + app-rankings models and a new Models.List sort param, but does not address any of the previously-raised blockers. They all still reproduce at b2f3e1d:
- 🔴 Streaming context-cancellation (open threads on the chat & responses send methods). The
defer cancel()guarding the per-call timeout cancels the context that the returned event stream captures. Confirmed against the stream runtime:Next()selects on the context'sDone()channel, andcancel()fires the instantSend()returns — so the first stream read immediately fails withcontext.Canceledwhenever an SDK/operation timeout is set. A real runtime bug on every streaming call configured with a timeout. - 🔴 Alias-less breaking type renames (open thread on the chat-request component).
Effort→ChatRequestEffortandReasoning→ChatRequestReasoningwere renamed with no compatibility aliases (verified absent), so every caller of the oldcomponents.Effort*constants breaks at compile time. - 🟡 Generator config (open thread on the gen config).
maxMethodParams: 4is the documented root cause of the recurring breaking-signature churn; setting it to0always emits a request object and lets params evolve without signature breaks.
New this push (in-scope):
- 🟡 The new Datasets
GetAppRankingsrepeats the paginationdefer cancel()footgun (same class as the existing BYOK / Observability pagination threads) — posted inline.
Codex (HEAVY_SECONDARY_MODEL): 2 findings on the Datasets service, both verified as generated-pattern artifacts with negligible practical impact under the documented usage (the example passes a fresh request literal): (1) a nil request pointer would deref-panic during query-param population — but no documented path passes nil; (2) the pagination closure mutates the caller-supplied request offset in place rather than a copy. Noted for the generator, not posted inline.
Research: Speakeasy pagination docs and Go context-cancellation methodology confirm the deferred-cancel-captured-context pattern breaks streaming and pagination reads. The Speakeasy maxMethodParams reference confirms setting maxMethodParams to 0 is the documented fix for signature stability across regens.
Security: no concerns — no secrets in the diff; auth header handling unchanged from the generated template; the new 403 Forbidden path is well-formed (added to the status-code matcher, has a matching case handler, and the ForbiddenResponseError type exists).
Build/vet: the package builds cleanly. go vet warnings (unreachable code, unexported deleted json-tag) are pre-existing Speakeasy generator patterns that also appear in files not in this diff — not introduced here.
Test coverage: none — generated SDK ships no unit tests; consistent with prior state, not a regression.
Unresolved threads: 17 open (all Perry-authored across prior rounds). The streaming context-cancellation blocker and the alias-less type renames should be resolved (ideally upstream in the spec / generator config) before this is mergeable.
Scope: first review (full) — no prior snapshot artifact on disk
Review: tier=large · model=claude-opus-latest · score=795.7
| if timeout != nil { | ||
| var cancel context.CancelFunc | ||
| ctx, cancel = context.WithTimeout(ctx, *timeout) | ||
| defer cancel() |
There was a problem hiding this comment.
[suggestion] defer cancel() cancels the ctx captured by the Next() pagination closure — GetAppRankings paginated with a configured timeout fails with context.Canceled
Details
Why: When a per-call or SDK-level Timeout is set, line 102-103 wraps ctx in context.WithTimeout and defer cancel()s it. The res.Next closure (line 223) captures that same ctx and re-invokes s.GetAppRankings(ctx, …) (line 263). But cancel() runs the instant the outer GetAppRankings returns — i.e. before the caller ever calls res.Next(). So the first Next() issues its request on an already-cancelled context and fails with context.Canceled. This is the same class of bug already flagged on byok.go:87 and observability.go pagination; datasets.go is new in this push and repeats it.
Fix: This is generator-driven — the durable fix is upstream (Speakeasy pagination + context handling), not a hand-edit to generated output. Either (a) don't bind the per-request timeout to the paginating context, or (b) re-derive a fresh timeout context inside each Next() invocation rather than reusing the cancelled parent.
Ref: Speakeasy pagination docs · Go context cancellation methodology
Prompt for agents
In `datasets.go`, `GetAppRankings` (line ~100) wraps the request context with `context.WithTimeout` + `defer cancel()`. The `res.Next` pagination closure at line ~223 captures this same `ctx` and reuses it when calling `s.GetAppRankings(ctx, request, opts...)` at line ~263. Because `cancel()` fires when the outer call returns, any `res.Next()` invoked by the caller hits an already-cancelled context and fails with context.Canceled whenever a timeout is configured. This is generated code, so fix it at the source: in the Speakeasy SDK config / generator, ensure paginated operations either do not bind the per-call timeout to the context captured by the Next closure, or re-establish a fresh timeout context per Next() call. The same pattern also affects byok.go and observability.go pagination.
Reviewed at b2f3e1d
There was a problem hiding this comment.
Perry's Review
Speakeasy-generated Go SDK regen (0.4.1 to 0.4.2): 293 generated Go files plus 644 docs plus Speakeasy lock/config, driven by an updated upstream OpenAPI spec. Adds preset-version endpoints, new server-tool types (fusion, web-fetch, shell, apply-patch), observability destinations, and assorted provider slugs and aspect ratios.
Verdict: 🔁 Needs changes
Details
Re-review note: This is a re-review of the latest push. Rather than re-post the 14 still-open inline findings from prior rounds, I verified the regen end-to-end and confirmed those findings remain valid against the current HEAD (42986f6) and are still not addressed. They are visible as existing unresolved review threads — I have intentionally not duplicated them inline (anti-re-review-spam).
Build and tests: go build passes, go test passes, go vet reports the usual Speakeasy generated-code patterns (unexported const JSON fields, unreachable post-return code) — all pre-existing on main (46 same-class findings on the base commit), not a regression from this push. All 293 changed Go files carry the "Code generated by Speakeasy" header — pure regen, zero hand-edits.
Still-open blockers (already posted inline in prior rounds; unaddressed):
- 🔴 chat.go and responses.go — Send() gained a required positional xOpenRouterMetadata argument, breaking every existing caller. Root cause is maxMethodParams set to 4 in the Speakeasy gen config; Speakeasy's own guidance is to set it to 0 so new fields stay additive on a request object (gen.yaml reference, handling breaking changes).
- 🔴 chat.go and responses.go (streaming) — defer cancel() tears down the timeout context the moment Send() returns, before the caller reads the returned EventStream, so streaming with any configured SDK or operation timeout fails with context.Canceled. This is the classic Speakeasy SSE plus WithTimeout footgun (Speakeasy SSE docs, Go context).
- 🔴 chatrequest.go — the Effort, Reasoning, and a FunctionCallOutputItem type were renamed (Effort to ChatRequestEffort, Reasoning to ChatRequestReasoning) with no compatibility aliases — breaking for any caller referencing the old names.
Still-open suggestions (already posted inline; unaddressed):
- 🟡 byok.go, datasets.go, observability.go — the same defer cancel() cancels the context captured by the Next() pagination closure, so a second-page fetch under a configured timeout fails.
- 🟡 byok.go and observability.go — pagination Next() final-page handling: the len(arr) less-than-limit check is dead code when limit is nil; the len(arr)==0 guard prevents an infinite loop but an extra empty fetch remains.
- 🟡 observability.go — the retry path runs AfterSuccess for final 4xx/5xx responses; AfterError hooks are skipped whenever retries are configured.
- 🟡 Doc examples (the chat and responses README streaming snippets) reference res.ChatStreamingResponse and res.ResponsesStreamingResponse, but the generated struct field is res.EventStream — the examples won't compile.
Codex (gpt-5.5) — one new observation (prose only, not raised inline):
- byok.go CreateBYOKKey retries a non-idempotent POST on 5XX. If the server processed the create but the response was lost, a retry can duplicate the BYOK credential. This is the spec-level x-speakeasy-retries policy applied uniformly to every method (not specific to this file), so the correct fix is in the upstream OpenAPI retry config, not in this generated PR. Noted for awareness; not raised as a blocker on a generated artifact.
Research: Confirmed the maxMethodParams breaking-signature mechanism and Speakeasy's recommendation to set it to 0; confirmed the defer cancel() plus streaming EventStream cancellation as a documented Go and Speakeasy-SSE pitfall.
Security: No secrets in the diff. No auth, API-key-handling, or tenant-isolation logic changed (generated provider-slug maps and DTOs only) — no concerns.
Test coverage: The SDK ships only internal/utils and optionalnullable unit tests; none exercise the generated client, streaming, or pagination paths. The streaming defer cancel() and pagination-termination bugs would be caught by even a minimal client-level test against a mock server — worth adding in the generator's test target upstream.
Unresolved threads: 14 active (non-outdated) plus 4 outdated from prior rounds — all Perry-authored, all still applicable, none re-posted here.
Scope: first review (full) — no prior diff snapshot persisted; reviewed the full diff (941 files, +71430 / -13528)
Review: tier=large · model=claude-opus-latest · score=849.6
There was a problem hiding this comment.
Perry's Review
Speakeasy regen bumping the Go SDK 0.4.1 → 0.4.2, adding the Design Arena benchmarks endpoint (GetBenchmarksDesignArena) plus Presets/Observability/BYOK surface — but shipping a wave of breaking method-signature and type-rename changes under a patch version bump.
Verdict: 🔁 Needs changes
Details
Scope: incremental re-review of the new push (head 5132639). The delta since my last review (42986f6) is 28 files / +1797 / -54 — almost entirely the new Design Arena benchmark types and the GetBenchmarksDesignArena method on the datasets service. That new endpoint is generated cleanly: correct numeric typing on win_rate/elo, standard retry+error-hook handling, and a non-paginated GET (no Next() closure, so the defer-cancel pagination footgun does not apply to it). No new findings on the added code.
Why this still needs changes: the new push did not address the outstanding blockers from prior reviews — they remain live as unresolved review threads on the current code (14 non-outdated unresolved threads). The headline issue is unchanged:
- This is a patch bump (0.4.1 → 0.4.2), but the generated release notes flag many changes as Breaking
⚠️ — Chat.Send / Beta.Responses.Send gained a new required positional parameter; Reasoning → ChatRequestReasoning, Effort → ChatRequestEffort, and FunctionCallOutputItemOutputType were renamed with no compatibility aliases. Every existing caller fails to compile after a routinego get -uwithin the 0.4.x line. - Root cause (already raised inline on the gen.yaml thread): maxMethodParams=4 makes Speakeasy emit positional params instead of a request object, so any added field reshapes the method signature. Speakeasy's automatic versioning only inspects info.version + the document checksum — it does not analyze content for breaking changes — so signature/type breaks register as a patch unless the bump is overridden.
Recommended remedy (no need to re-litigate the existing inline threads — they cover the specifics):
- Set maxMethodParams=0 in gen.yaml so methods take an evolvable request object and future field additions stop breaking signatures.
- For this release, force the correct bump (SPEAKEASY_BUMP_OVERRIDE=major, or a PR "major" label). Note: for a pre-1.0 Go SDK Speakeasy downgrades an automatic major to minor, and crossing 1.0 later requires a "/v2" import-path change — so decide the versioning story deliberately rather than letting it ship silent as a patch.
Pre-existing generator footguns also still open (flagged inline previously, unchanged by this push): defer cancel() cancelling the streaming/pagination context before the caller reads it (chat/responses/byok/datasets), the "len(arr) < l" pagination terminator that never fires when limit is nil, the retry path invoking AfterSuccess on final 4xx/5xx, and two doc examples referencing response fields that don't exist on the generated types.
CI: no checks configured on this repo — nothing to report (not a gate on the verdict).
Codex (gpt-5.5): one finding surfaced (datasets.go Next() nil-deref); discarded after verification — GetAppRankings documents request as required and the usage example passes a non-nil value, so the premise was false.
Research: Speakeasy versioning + breaking-changes docs — confirmed auto-versioning keys only on info.version/checksum (not content), and maxMethodParams=0 plus SPEAKEASY_BUMP_OVERRIDE are the documented mitigations.
Security: no concerns — generated client SDK + docs; secret-pattern scan over added lines is clean (example credentials are server-masked placeholders).
Test coverage: generated SDK; no hand-written tests in scope.
Unresolved threads: 14 non-outdated unresolved threads from prior reviews remain — all still applicable to the current code. Not re-posted here to avoid duplication.
Scope: incremental — only the Design Arena endpoint is net-new since the prior review
Review: tier=large · model=claude-opus-latest · score=867.1
There was a problem hiding this comment.
Perry's Review
Speakeasy SDK regen 0.4.1 → 0.4.2: adds Observability, Presets, BYOK, Datasets, STT and Beta Analytics operation groups, an additive Messages fallbacks field, and error.OpenrouterMetadata across many ops — but ships ~15 breaking API changes under a patch version bump and re-introduces no fixes for the previously-flagged streaming/pagination context-cancellation bugs.
Verdict: 🔁 Needs changes
Details
Scope: incremental — only ~137 new lines since my prior review (the additive Messages fallbacks field + its generated param type). The rest of the diff is unchanged from the SHA I last reviewed.
Risk: 🔴 High — human approval required (touches the streaming/SSE response path and ships a breaking public API surface change)
CI: no checks reported on the head commit (no required checks configured on this repo).
What changed since my last review (in-scope, clean):
- New optional
fallbacksfield on the Messages request (OptionalNullable, omitzero) + a generatedMessagesFallbackParamtype. Purely additive, existing constructors unaffected — no new findings.
Standing blockers — still unaddressed (18 open review threads from prior rounds):
- Streaming context cancellation —
defer cancel()on the timeout context fires whenSend()returns, cancelling the context the returned EventStream still reads from. Any configured SDK/operation timeout makes streaming fail immediately withcontext canceled. Affects both the chat and responses streaming paths. (Confirmed against Go context semantics — see Research.) - Pagination context cancellation — the same
defer cancel()pattern cancels the context captured by theNext()pagination closure in the new BYOK, Observability and Datasets list operations; callingNext()after the first call fails once a timeout is configured. - Pagination never terminates / overshoots — the
Next()termination check (len(arr) < limit) never fires whenlimitis nil, and offset can advance past the API maximum after a full final page (400 instead of clean end). - Breaking type renames without aliases — the Reasoning/Effort types (and a function-call output type) were renamed, breaking every caller referencing the old
components.*identifiers, with no compatibility alias. - Breaking method signatures from
maxMethodParams: 4— the param-count generator setting is the root cause of recurring breakingSend()signature churn on every regen; setting it to0produces a stable request-struct-only signature. - Doc examples reference non-existent stream fields — several README/SDK-doc SSE snippets reference response stream fields that do not exist on the generated response structs (and omit the stream flag), so the examples will not compile.
Versioning (root cause): Speakeasy versioningStrategy: automatic derives the bump from generator + OpenAPI + config deltas, taking the largest. The OpenAPI changes here are breaking, yet the release landed as patch (0.4.1 → 0.4.2, PR labelled patch). For a pre-1.0 SDK Speakeasy downgrades a detected major to a minor — so the correct bump for these breaking changes is 0.5.0, not a patch. A patch release carrying breaking changes violates SemVer expectations downstream consumers rely on.
Codex (gpt-5.5): surfaced only the SSE doc-field and Datasets pagination-overshoot issues — both already covered by the standing open threads above. No net-new findings.
Research: Speakeasy SDK versioning docs (largest-of-three-inputs bump; pre-1.0 major→minor downgrade) and Go context cancellation semantics (defer cancel before a streamed body read yields context canceled) — both confirm the standing findings.
Security: secret scan over added lines — no committed credentials. Streaming/SSE response path touched (category 2); the cancellation bug is a correctness issue, not an exfiltration vector.
Test coverage: generated SDK with test generation disabled in gen.yaml; the context-cancellation and pagination bugs have no regression coverage.
Unresolved threads: 18 open — all prior Perry findings listed above. No new inline comments posted this round (the only new code since my last review is the additive fallbacks field, which is clean); re-posting the standing findings would duplicate the existing open threads.
Scope: incremental — ~137 new lines since prior review
Review: tier=large · model=claude-opus-latest · score=866.80.0
There was a problem hiding this comment.
Perry's Review
Speakeasy SDK regeneration to v0.4.2 — adds the BYOK, Observability, Presets, STT, BetaAnalytics, and Design-Arena / Artificial-Analysis benchmark surfaces, plus new ChatRequest sampling params (min_p, top_a, top_k, repetition_penalty, reasoning_effort). Ships breaking API changes under a patch version bump.
Verdict: 🔁 Needs changes
Details
Risk: 🔴 High — human approval required (breaking public-API change shipped under a patch tag; immutable once published to the Go module proxy).
CI: no checks configured on the head SHA — not an approval gate.
Scope: incremental re-review. Since the last reviewed SHA (701cc28) the only changes are 3 generated model files: models/components/chatrequest.go (+72), models/components/aabenchmarkentry.go (new), and models/components/modelbenchmarks.go (+30/-3). All new lines are clean additive generated code — new optional sampling fields plus their getters, and the AABenchmarkEntry type wired into ModelBenchmarks. No new findings on the delta.
Standing blockers — unchanged since the last review; see the existing inline threads, none resolved:
- 🔴 Breaking changes shipped under a patch bump (0.4.1 → 0.4.2). For a pre-1.0 SDK a breaking change should be a minor bump (0.5.0).
chat.goandresponses.goSend gained a positional xOpenRouterMetadata param; Effort → ChatRequestEffort, Reasoning → ChatRequestReasoning, Category → GetModelsCategory, and FunctionCallOutputItemOutputType were renamed — every downstream consumer that compiled against 0.4.1 breaks. Root cause: Speakeasy only escalates the bump when the OpenAPI info.version carries a SemVer increment; bump info.version upstream so the regen produces 0.5.0. - 🔴 In
.speakeasy/gen.yaml, maxMethodParams: 4 is the structural root cause of the recurring breaking-signature churn — set it to 0 to force request objects so future param additions stay non-breaking. - 🟡 Streaming defer-cancel in
chat.goandresponses.gocancels the timeout context before the caller reads the EventStream. This is pre-existing generated boilerplate, not introduced here, but still active and unaddressed. - 🟡 Pagination defer-cancel plus nil-limit termination in the new
byok.go,datasets.go,observability.go, andpresets.go: the Next closure captures a context the parent's defer-cancel has already cancelled, and the len(arr) < l guard never fires when limit is nil.
Codex (HEAVY_SECONDARY_MODEL): no additional findings — the analysis hit the time cap on this 88k-LoC diff and produced no usable output.
Research: Speakeasy versioning docs (https://www.speakeasy.com/docs/sdks/manage/versioning) — pre-1.0 breaking changes downgrade to a minor bump, and the bump is driven by the OpenAPI info.version SemVer delta (not content analysis), so a config-only checksum change yields just a patch. Speakeasy methods docs (https://www.speakeasy.com/docs/sdks/customize/methods) — maxMethodParams: 0 forces a request object, making future field additions backward-compatible. Go context docs (https://pkg.go.dev/context) confirm the defer-cancel streaming footgun: the context's lifetime must fully contain the body read.
Security: no concerns — the diff is generated SDK plus docs; no real secrets (BYOK key fields are masked, e.g. label "sk-...AbCd"), no hand-written auth or validation logic.
Test coverage: generated SDK — no unit tests in the diff; correctness is governed by the OpenAPI spec and generator config, which is why the versioning and maxMethodParams fixes belong upstream.
Unresolved threads: ~13 active Perry threads from prior rounds remain open and unaddressed — they are the standing blockers above. This incremental re-review adds no new inline comments because the new delta is clean.
Scope: incremental — 0 new findings since prior review (delta is 3 clean generated files)
Review: tier=large · model=claude-opus-latest · score=884.0
There was a problem hiding this comment.
Perry's Review
Speakeasy SDK regeneration (0.4.1 to 0.4.2) that adds a new Artificial Analysis benchmarks endpoint and regenerates the full client; the new endpoint is clean, but several breaking API changes from prior pushes remain unaddressed and are still shipped under a patch bump.
Verdict: 🔁 Needs changes
Details
Risk: 🔴 High — human approval required (touches the streaming response path and ships breaking public-API changes)
CI: no checks configured on this repo (0 check runs, 0 statuses on the head commit)
What's new since my last review (incremental scope): the only net-new code is the Artificial Analysis benchmarks endpoint — a new GetBenchmarksArtificialAnalysis method on Datasets plus its generated models (BenchmarksAAItem / BenchmarksAAMeta / BenchmarksAAResponse) and docs. This delta is clean: a standard generated non-streaming GET, proper OptionalNullable handling, no new footguns. ✅
Standing blockers (carried forward — already have open review threads, not re-posted inline to avoid duplicate spam):
- Breaking Chat.Send / Responses.Send signature change — a new positional metadata parameter (see the two inline comments on this push; the parameter was renamed from the earlier ExperimentalMetadata form but remains breaking).
- Breaking type renames with no compatibility aliases: Effort to ChatRequestEffort, Reasoning to ChatRequestReasoning, and FunctionCallOutputItemOutputType renamed (existing unresolved threads on the chatrequest and functioncalloutputitem components).
- The deferred cancel cancels the streaming context before the caller reads the returned EventStream, in both the chat and responses send paths (existing unresolved threads). This is a well-documented Go gotcha — the timeout context is torn down on function return while the body is still being streamed.
- Pagination Next closures capture a context that the parent's deferred cancel tears down, and never terminate when limit is nil (the local limit defaults to 0, so the len-less-than-limit guard never fires) — existing unresolved threads on the byok, observability, and datasets pagination paths.
- Root cause of the recurring signature breakage: maxMethodParams is set to 4 in the Speakeasy generator config, which flattens added OpenAPI parameters straight into method signatures (existing unresolved thread on the generator config).
- A patch version bump (0.4.1 to 0.4.2) understates these breaking changes; per pre-1.0 SemVer convention this should be a 0.5.0 minor.
Codex (gpt-5.5): 2 findings surfaced; both rejected on verification — one (a datasets pagination nil-deref panic) is a false positive (the code uses OptionalNullable Get with a proper nil guard), the other (analytics rows generated as empty structs from a bare object schema) is a real modeling weakness but is pre-existing on the prior reviewed commit and outside this push's delta.
Research: SemVer 2.0.0 section 4 — the pre-1.0 convention treats minor as the breaking indicator and patch as backward-compatible (and Go/npm caret plus patch-level upgrades auto-resolve patch bumps, so a breaking patch silently reaches consumers). Speakeasy docs confirm setting maxMethodParams to 0 forces a request-object signature so added params are non-breaking. Go context docs and community guidance confirm the deferred-cancel-before-stream-read pattern cancels the request as soon as the function returns.
Security: streaming response path touched (Step 6c category 2) — no credential-exposure or injection concerns; the streaming finding is a correctness/reliability bug, not a security one. No secrets detected in the diff.
Test coverage: generated SDK; no unit tests accompany the regenerated client paths. The breaking-signature and context-cancellation issues would not be caught by any test in this repo.
Unresolved threads: ~16 active Perry threads from prior review rounds remain open, covering the standing blockers above. They are intentionally not duplicated here.
Scope: incremental — additive AA-benchmarks endpoint since prior reviewed commit 41a95fa; standing blockers carried forward
Review: tier=large · model=claude-opus-latest · score=881.9
| // Send - Create a chat completion | ||
| // Sends a request for a model response for the given chat conversation. Supports both streaming and non-streaming modes. | ||
| func (s *Chat) Send(ctx context.Context, request components.ChatRequest, opts ...operations.Option) (*operations.SendChatCompletionRequestResponse, error) { | ||
| func (s *Chat) Send(ctx context.Context, chatRequest components.ChatRequest, xOpenRouterMetadata *components.MetadataLevel, opts ...operations.Option) (*operations.SendChatCompletionRequestResponse, error) { |
There was a problem hiding this comment.
[blocker] Chat.Send adds a new positional xOpenRouterMetadata *components.MetadataLevel parameter — breaks every existing caller, shipped under a patch bump (0.4.1 → 0.4.2).
Details
Why: The signature went from Send(ctx, request, opts...) to Send(ctx, chatRequest, xOpenRouterMetadata, opts...). Any consumer calling client.Chat.Send(ctx, req) now fails to compile — xOpenRouterMetadata is positional (before the variadic opts), not optional. For a pre-1.0 SDK, SemVer convention treats the minor digit as the breaking-change indicator and the patch digit as backward-compatible; Go module consumers on v0.4.x will silently pull this via go get -u=patch. This is the recurring root cause flagged across prior reviews: maxMethodParams: 4 in .speakeasy/gen.yaml flattens added OpenAPI params straight into the method signature.
Fix: Set maxMethodParams: 0 in .speakeasy/gen.yaml so Speakeasy always generates a single request object (new fields become non-breaking additions), and cut this release as 0.5.0 (minor) rather than 0.4.2 (patch).
Ref: Speakeasy — Customize methods (maxMethodParams) · SemVer 2.0.0 §4 (0.x.y)
Prompt for agents
In .speakeasy/gen.yaml set `maxMethodParams: 0` (currently 4) so the Go generator emits a single request-object parameter for every method instead of flattening OpenAPI parameters into positional args. Regenerate the SDK. This restores a stable `Chat.Send(ctx, request, opts...)` / `Responses.Send(ctx, request, opts...)` signature and makes future parameter additions non-breaking. Additionally, bump the release version in .speakeasy/gen.yaml and gen.lock from 0.4.2 to 0.5.0 (minor), since the change set still carries breaking API changes and a pre-1.0 patch bump understates that.
Reviewed at f1bba19
| @@ -35,7 +35,12 @@ func newResponses(rootSDK *OpenRouter, sdkConfig config.SDKConfiguration, hooks | |||
|
|
|||
| // Send - Create a response | |||
| // Creates a streaming or non-streaming response using OpenResponses API format | |||
| func (s *Responses) Send(ctx context.Context, request components.ResponsesRequest, opts ...operations.Option) (*operations.CreateResponsesResponse, error) { | |||
| func (s *Responses) Send(ctx context.Context, responsesRequest components.ResponsesRequest, xOpenRouterMetadata *components.MetadataLevel, opts ...operations.Option) (*operations.CreateResponsesResponse, error) { | |||
There was a problem hiding this comment.
[blocker] Responses.Send — same breaking positional xOpenRouterMetadata *components.MetadataLevel parameter as Chat.Send, under a patch bump.
Details
Why: Identical failure mode to the Chat.Send finding: a new positional parameter inserted before the variadic opts ...operations.Option breaks every existing Responses.Send(ctx, req) call site. Same root cause (maxMethodParams: 4), same SemVer concern (breaking change shipped as 0.4.1 → 0.4.2 patch).
Fix: Addressed by the same maxMethodParams: 0 + 0.5.0 minor-bump remedy described on the Chat.Send comment — no separate change needed here once the generator config is fixed and the SDK is regenerated.
Prompt for agents
This is the same issue as the Chat.Send blocker — fixing `maxMethodParams: 0` in .speakeasy/gen.yaml and regenerating the SDK resolves both Send signatures at once. No file-specific edit to responses.go is required; it is generated output. Verify after regeneration that Responses.Send returns to a `Send(ctx, request, opts...)` shape.
Reviewed at f1bba19
There was a problem hiding this comment.
Perry's Review
Speakeasy SDK regen to 0.4.2 — this push adds a generated web-search server-tool model family (WebSearchServerTool + preview/legacy variants, WebSearchEngineEnum, WebSearchConfig, ChatWebSearchShorthand, SearchQualityLevel) and wires them into the existing tool unions.
Verdict: 🔁 Needs changes
Details
Incremental re-review — 6th review of this PR. Only the ~62 new lines since my last pass (the web-search tool types + lock/spec updates) are in scope here; I did not re-litigate code I reviewed on prior pushes.
New since last review (in scope) — clean ✅:
- 10 new generated files (5 Go types + 5 docs) modelling the OpenRouter web-search server tool. Verified the whole module compiles cleanly (go build over all packages), and the new types are correctly spliced into OpenResponsesResultToolUnion and ChatFunctionToolUnion.
- The generated surface faithfully matches the documented OpenRouter web-search API: engines auto/native/exa/firecrawl/parallel/perplexity, max_results / max_total_results, search_context_size (low/medium/high), allowed/excluded domain filters (mutually exclusive), max_characters precedence, and user_location. No new findings.
- Note: two engine enums now coexist — WebSearchEngine (no "auto", used by the legacy WebSearchPlugin) and WebSearchEngineEnum (with "auto", used by the new server tools). This mirrors the real API distinction and is generated correctly, not a defect.
Standing blockers (unchanged — 20 unresolved threads from prior pushes):
- Breaking Send-signature change (new positional metadata param on Chat.Send / Responses.Send) and the Effort/Reasoning → ChatRequestEffort/ChatRequestReasoning type renames are still shipping under a patch bump (0.4.2). Per Speakeasy's own rules a breaking change on a pre-v1 Go SDK should bump minor (0.5.0), not patch. Root cause remains the maxMethodParams=4 generator config.
- The defer cancel() streaming/pagination footguns flagged previously remain present.
- See the existing unresolved review threads for the full inline detail + fixes — I have not re-posted them to avoid duplicate noise.
CI: no checks reported on the head commit.
Codex (HEAVY_SECONDARY_MODEL): findings surfaced (datasets.go pagination, README SSE example) all fall in already-reviewed code with open threads — not re-raised.
Research: Speakeasy SDK versioning docs (Go SDKs downgrade major→minor; breaking change ⇒ minor for pre-v1) and the OpenRouter web-search server-tool API reference — the new types match the spec.
Security: no concerns — secret scan clean; delta is additive generated config types with no auth/streaming/logging code.
Test coverage: generated SDK; no hand-written tests in the delta (expected for codegen output).
Unresolved threads: 20 open Perry threads carrying the standing breaking-change + lifecycle blockers above.
Scope: incremental — ~62 new lines since prior review
Review: tier=large · model=claude-opus-latest · score=883.1
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
* `OpenRouter.Chat.Send()`: * `request` **Changed** (Breaking⚠️ ) * `response` **Changed** * `error` **Changed** * `OpenRouter.VideoGeneration.Generate()`: * `request.Request` **Changed** (Breaking⚠️ ) * `error.OpenrouterMetadata` **Added** * `OpenRouter.Beta.Responses.Send()`: * `request` **Changed** (Breaking⚠️ ) * `response` **Changed** (Breaking⚠️ ) * `error` **Changed** * `OpenRouter.Rerank.Rerank()`: * `request.Request` **Changed** (Breaking⚠️ ) * `response.Results[].Document` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Models.ListForUser()`: * `response.Data[]` **Changed** (Breaking⚠️ ) * `error.OpenrouterMetadata` **Added** * `OpenRouter.Models.List()`: * `request` **Changed** (Breaking⚠️ ) * `response.Data[]` **Changed** (Breaking⚠️ ) * `error.OpenrouterMetadata` **Added** * `OpenRouter.Generations.GetGeneration()`: * `response.Data` **Changed** (Breaking⚠️ ) * `error.OpenrouterMetadata` **Added** * `OpenRouter.Endpoints.List()`: * `response.Data` **Changed** (Breaking⚠️ ) * `error.OpenrouterMetadata` **Added** * `OpenRouter.Endpoints.ListZdrEndpoints()`: * `response.Data[].ProviderName` **Changed** (Breaking⚠️ ) * `error.OpenrouterMetadata` **Added** * `OpenRouter.Embeddings.ListModels()`: * `response.Data[]` **Changed** (Breaking⚠️ ) * `error.OpenrouterMetadata` **Added** * `OpenRouter.Embeddings.Generate()`: * `request.Request` **Changed** (Breaking⚠️ ) * `response.Usage.PromptTokensDetails.FileTokens` **Added** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Observability.Create()`: **Added** * `OpenRouter.Guardrails.Delete()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Files.Upload()`: **Added** * `OpenRouter.Files.Delete()`: **Added** * `OpenRouter.Files.Retrieve()`: **Added** * `OpenRouter.Files.Download()`: **Added** * `OpenRouter.Models.Get()`: **Added** * `OpenRouter.Observability.List()`: **Added** * `OpenRouter.Beta.Analytics.GetAnalyticsMeta()`: **Added** * `OpenRouter.Observability.Delete()`: **Added** * `OpenRouter.Observability.Get()`: **Added** * `OpenRouter.Observability.Update()`: **Added** * `OpenRouter.Presets.List()`: **Added** * `OpenRouter.Presets.Get()`: **Added** * `OpenRouter.Presets.CreatePresetsChatCompletions()`: **Added** * `OpenRouter.Presets.CreatePresetsMessages()`: **Added** * `OpenRouter.Presets.CreatePresetsResponses()`: **Added** * `OpenRouter.Presets.ListVersions()`: **Added** * `OpenRouter.Presets.GetVersion()`: **Added** * `OpenRouter.Analytics.GetUserActivity()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Tts.CreateSpeech()`: * `request.Request.Provider.Options` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.OAuth.ExchangeAuthCodeForApiKey()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.OAuth.CreateAuthCode()`: * `request.Request.WorkspaceId` **Added** * `error` **Changed** * `OpenRouter.Datasets.GetRankingsDaily()`: **Added** * `OpenRouter.Credits.GetCredits()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Datasets.GetBenchmarksDesignArena()`: **Added** * `OpenRouter.Datasets.GetBenchmarksArtificialAnalysis()`: **Added** * `OpenRouter.Datasets.GetAppRankings()`: **Added** * `OpenRouter.Byok.Update()`: **Added** * `OpenRouter.Byok.Get()`: **Added** * `OpenRouter.Generations.ListGenerationContent()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.List()`: * `response.Data[]` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.Create()`: * `request.Request` **Changed** * `response.Data` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Files.List()`: **Added** * `OpenRouter.Guardrails.Get()`: * `response.Data` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.Update()`: * `request.UpdateGuardrailRequest` **Changed** * `response.Data` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.ListGuardrailKeyAssignments()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.BulkAssignKeys()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.BulkUnassignKeys()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.ListGuardrailMemberAssignments()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.BulkAssignMembers()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.BulkUnassignMembers()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.ListKeyAssignments()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Guardrails.ListMemberAssignments()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.ApiKeys.GetCurrentKeyMetadata()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.ApiKeys.List()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.ApiKeys.Create()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.ApiKeys.Delete()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.ApiKeys.Get()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.ApiKeys.Update()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Byok.Delete()`: **Added** * `OpenRouter.Models.Count()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Byok.Create()`: **Added** * `OpenRouter.Organization.ListMembers()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Providers.List()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Byok.List()`: **Added** * `OpenRouter.Stt.CreateTranscription()`: **Added** * `OpenRouter.Beta.Analytics.QueryAnalytics()`: **Added** * `OpenRouter.VideoGeneration.GetGeneration()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.VideoGeneration.GetVideoContent()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.VideoGeneration.ListVideosModels()`: * `response.Data[]` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Workspaces.List()`: * `response.Data[]` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Workspaces.Create()`: * `request.Request` **Changed** * `response.Data` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Workspaces.Delete()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Workspaces.Get()`: * `response.Data` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Workspaces.Update()`: * `request.UpdateWorkspaceRequest` **Changed** * `response.Data` **Changed** * `error.OpenrouterMetadata` **Added** * `OpenRouter.Workspaces.BulkAddMembers()`: `error.OpenrouterMetadata` **Added** * `OpenRouter.Workspaces.BulkRemoveMembers()`: `error.OpenrouterMetadata` **Added**
There was a problem hiding this comment.
Perry's Review
Speakeasy regen to SDK v0.5.0 (newer CLI 1.778.0); since my last review at 45df551 the branch was force-pushed — the genuinely new code is a clean 67-file / +404-292 delta of internals fixes, but the 22 findings I previously raised are all still present and unaddressed at HEAD.
Verdict: 💬 Comments / questions
Details
Risk: 🔴 High — human approval required (touches the streaming/SSE response path + ships breaking public-API signatures under a "minor" label)
CI: none reported on de4d404 (commit status pending/empty)
What changed since my last review (force-push 45df551 → de4d404):
- 🟢
types/stream/stream.go— SSE scanner now sets a 1 GiBscanner.Bufferand a stateful splitter that only re-scans the trailing 3 bytes. This fixes a real latent bug: the oldbufio.NewScannerused the default 64 KiB token cap, so any single SSE event > 64 KiB would have failed withbufio.Scanner: token too long. Verified correct against the W3C EventSource boundary rules. ✅ - 🟢
internal/utils/union.go—countFieldsRecursiveno longer calls.Elem()/.IsNil()unconditionally on union variants, fixing a panic on non-pointer variants (slice/map/any). Backed by a new table-driven test (TestPickBestUnionCandidate_NonPointerUnionVariants). ✅ - 🟢
internal/utils/json.go— map fields implementingjson.Unmarshalernow delegate to the custom unmarshaler. ✅ - 🟢
models/components/urlcitation.go— additiveContent *stringfield +GetContent(). ✅ - 🟢 service files: explicit status-code error lists (
["400","401",…,"524","529",…]) collapsed to["4XX","5XX"]. Verified semantically equivalent viaMatchStatusCodes(wildcard4XX/5XXcovers every previously-enumerated code, including the non-standard 524/529). ✅ - 🟡
go.mod—go 1.22→go 1.25.10(see inline comment).
Both the build (go build) and the unit tests for the changed packages pass in the worktree.
Findings (1 net-new; see inline comment):
- 🟡
go.mod:3— full-patch version floorgo 1.25.10over-constrains SDK consumers.
Still-open prior findings (unchanged by this force-push — 22 threads): breaking positional xOpenRouterMetadata on Chat.Send/Responses.Send; defer cancel() cancelling the streaming context before the caller reads it (chat.go:79, responses.go:80); pagination Next() non-termination (byok.go, observability.go, datasets.go); Reasoning/Effort type renames; empty QueryAnalyticsData1; maxMethodParams: 4 as the recurring root cause of breaking signatures. None were addressed — they were re-emitted verbatim by the regen.
Codex (gpt-5.5): 2 findings (QueryAnalytics empty struct; GetAppRankings offset overrun) — both already on record in the prior threads; no net-new.
Research: Go module go directive semantics (go.dev/ref/mod — full-patch floor vs language-version family); W3C/WHATWG SSE boundary + Go bufio.Scanner 64 KiB ErrTooLong — confirms the stream change is a genuine fix.
Security: streaming/SSE path touched (Step 6c cat. 2) — change is a robustness fix, no exfiltration/validation-bypass surface; no secrets in the delta.
Test coverage: new union behaviour covered; the SSE splitter has no in-repo test (types/stream has no _test.go).
Unresolved threads: 22 (all Perry-authored, all still applicable at HEAD).
Scope: incremental — ~404 new lines since prior review (force-push)
Review: tier=large · model=claude-opus-latest · score=937.7
| @@ -1,6 +1,6 @@ | |||
| module github.com/OpenRouterTeam/go-sdk | |||
|
|
|||
| go 1.22 | |||
| go 1.25.10 | |||
There was a problem hiding this comment.
[suggestion] go 1.25.10 — pinning a full patch version as the module floor forces every SDK consumer onto Go ≥ 1.25.10
Details
Why: Since Go 1.21 the go directive is a hard minimum, not advisory — a toolchain older than the declared version refuses to build the module (go: go.mod requires go >= 1.25.10). The patch-level form 1.25.10 is the strictest possible floor: a consumer on Go 1.25.9 (or any earlier 1.25.x) cannot build this SDK at all, even though there are no language features here that need 1.25.10 specifically. This jumped from go 1.22 in one regen and ships under a minor-labeled 0.5.0 release, so it is an unannounced, consumer-affecting toolchain requirement.
For a published library the idiomatic choice is the language-version form (go 1.25, or even keep go 1.22 if no ≥1.23 language features are actually used), which permits any patch in that family, and a separate toolchain directive if a specific build version is desired. The patch-pinned floor is a generator artifact, not a deliberate compatibility decision — worth confirming the bump is intended.
Fix:
go 1.25
(or restore go 1.22 if no 1.23+ language features are used; add toolchain go1.25.10 separately only if you want to suggest — not require — that exact build version)
Ref: Go Modules Reference — go directive & version syntax · Go Toolchains
Prompt for agents
In go.mod:3, the `go` directive was changed from `go 1.22` to `go 1.25.10`. A full-patch-version floor forces every consumer of this SDK onto Go >= 1.25.10 and breaks builds on any earlier 1.25.x. If this strict floor is not intentional, change it to the language-version form `go 1.25` (permits any 1.25.x patch), or restore `go 1.22` if no Go 1.23+ language features are used. If a specific build toolchain is genuinely desired, express it via a separate `toolchain go1.25.10` directive rather than raising the consumer-facing minimum. This is a Speakeasy generator setting — check `.speakeasy/gen.yaml` / the generation config for what controls the emitted go version.
Reviewed at de4d404
2 participants
SDK update
Versioning
Version Bump Type: [minor] - 🤖 (automated)
Tip
If updates to your OpenAPI document introduce breaking changes, be sure to update the
info.versionfield to trigger the correct version bump.Speakeasy supports manual control of SDK versioning through multiple methods.
Go SDK Changes:
OpenRouter.Chat.Send():requestChanged (BreakingresponseChangederrorChangedOpenRouter.VideoGeneration.Generate():request.RequestChanged (Breakingerror.OpenrouterMetadataAddedOpenRouter.Beta.Responses.Send():requestChanged (BreakingresponseChanged (BreakingerrorChangedOpenRouter.Rerank.Rerank():request.RequestChanged (Breakingresponse.Results[].DocumentChangederror.OpenrouterMetadataAddedOpenRouter.Models.ListForUser():response.Data[]Changed (Breakingerror.OpenrouterMetadataAddedOpenRouter.Models.List():requestChanged (Breakingresponse.Data[]Changed (Breakingerror.OpenrouterMetadataAddedOpenRouter.Generations.GetGeneration():response.DataChanged (Breakingerror.OpenrouterMetadataAddedOpenRouter.Endpoints.List():response.DataChanged (Breakingerror.OpenrouterMetadataAddedOpenRouter.Endpoints.ListZdrEndpoints():response.Data[].ProviderNameChanged (Breakingerror.OpenrouterMetadataAddedOpenRouter.Embeddings.ListModels():response.Data[]Changed (Breakingerror.OpenrouterMetadataAddedOpenRouter.Embeddings.Generate():request.RequestChanged (Breakingresponse.Usage.PromptTokensDetails.FileTokensAddederror.OpenrouterMetadataAddedOpenRouter.Observability.Create(): AddedOpenRouter.Guardrails.Delete():error.OpenrouterMetadataAddedOpenRouter.Files.Upload(): AddedOpenRouter.Files.Delete(): AddedOpenRouter.Files.Retrieve(): AddedOpenRouter.Files.Download(): AddedOpenRouter.Models.Get(): AddedOpenRouter.Observability.List(): AddedOpenRouter.Beta.Analytics.GetAnalyticsMeta(): AddedOpenRouter.Observability.Delete(): AddedOpenRouter.Observability.Get(): AddedOpenRouter.Observability.Update(): AddedOpenRouter.Presets.List(): AddedOpenRouter.Presets.Get(): AddedOpenRouter.Presets.CreatePresetsChatCompletions(): AddedOpenRouter.Presets.CreatePresetsMessages(): AddedOpenRouter.Presets.CreatePresetsResponses(): AddedOpenRouter.Presets.ListVersions(): AddedOpenRouter.Presets.GetVersion(): AddedOpenRouter.Analytics.GetUserActivity():error.OpenrouterMetadataAddedOpenRouter.Tts.CreateSpeech():request.Request.Provider.OptionsChangederror.OpenrouterMetadataAddedOpenRouter.OAuth.ExchangeAuthCodeForApiKey():error.OpenrouterMetadataAddedOpenRouter.OAuth.CreateAuthCode():request.Request.WorkspaceIdAddederrorChangedOpenRouter.Datasets.GetRankingsDaily(): AddedOpenRouter.Credits.GetCredits():error.OpenrouterMetadataAddedOpenRouter.Datasets.GetBenchmarksDesignArena(): AddedOpenRouter.Datasets.GetBenchmarksArtificialAnalysis(): AddedOpenRouter.Datasets.GetAppRankings(): AddedOpenRouter.Byok.Update(): AddedOpenRouter.Byok.Get(): AddedOpenRouter.Generations.ListGenerationContent():error.OpenrouterMetadataAddedOpenRouter.Guardrails.List():response.Data[]Changederror.OpenrouterMetadataAddedOpenRouter.Guardrails.Create():request.RequestChangedresponse.DataChangederror.OpenrouterMetadataAddedOpenRouter.Files.List(): AddedOpenRouter.Guardrails.Get():response.DataChangederror.OpenrouterMetadataAddedOpenRouter.Guardrails.Update():request.UpdateGuardrailRequestChangedresponse.DataChangederror.OpenrouterMetadataAddedOpenRouter.Guardrails.ListGuardrailKeyAssignments():error.OpenrouterMetadataAddedOpenRouter.Guardrails.BulkAssignKeys():error.OpenrouterMetadataAddedOpenRouter.Guardrails.BulkUnassignKeys():error.OpenrouterMetadataAddedOpenRouter.Guardrails.ListGuardrailMemberAssignments():error.OpenrouterMetadataAddedOpenRouter.Guardrails.BulkAssignMembers():error.OpenrouterMetadataAddedOpenRouter.Guardrails.BulkUnassignMembers():error.OpenrouterMetadataAddedOpenRouter.Guardrails.ListKeyAssignments():error.OpenrouterMetadataAddedOpenRouter.Guardrails.ListMemberAssignments():error.OpenrouterMetadataAddedOpenRouter.ApiKeys.GetCurrentKeyMetadata():error.OpenrouterMetadataAddedOpenRouter.ApiKeys.List():error.OpenrouterMetadataAddedOpenRouter.ApiKeys.Create():error.OpenrouterMetadataAddedOpenRouter.ApiKeys.Delete():error.OpenrouterMetadataAddedOpenRouter.ApiKeys.Get():error.OpenrouterMetadataAddedOpenRouter.ApiKeys.Update():error.OpenrouterMetadataAddedOpenRouter.Byok.Delete(): AddedOpenRouter.Models.Count():error.OpenrouterMetadataAddedOpenRouter.Byok.Create(): AddedOpenRouter.Organization.ListMembers():error.OpenrouterMetadataAddedOpenRouter.Providers.List():error.OpenrouterMetadataAddedOpenRouter.Byok.List(): AddedOpenRouter.Stt.CreateTranscription(): AddedOpenRouter.Beta.Analytics.QueryAnalytics(): AddedOpenRouter.VideoGeneration.GetGeneration():error.OpenrouterMetadataAddedOpenRouter.VideoGeneration.GetVideoContent():error.OpenrouterMetadataAddedOpenRouter.VideoGeneration.ListVideosModels():response.Data[]Changederror.OpenrouterMetadataAddedOpenRouter.Workspaces.List():response.Data[]Changederror.OpenrouterMetadataAddedOpenRouter.Workspaces.Create():request.RequestChangedresponse.DataChangederror.OpenrouterMetadataAddedOpenRouter.Workspaces.Delete():error.OpenrouterMetadataAddedOpenRouter.Workspaces.Get():response.DataChangederror.OpenrouterMetadataAddedOpenRouter.Workspaces.Update():request.UpdateWorkspaceRequestChangedresponse.DataChangederror.OpenrouterMetadataAddedOpenRouter.Workspaces.BulkAddMembers():error.OpenrouterMetadataAddedOpenRouter.Workspaces.BulkRemoveMembers():error.OpenrouterMetadataAddedView full SDK changelog
OpenAPI Change Summary