Skip to content

Fix Crash in Tracker Effect (when frame size changes) #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonoomph merged 1 commit into from
Mar 14, 2026
Merged

Fix Crash in Tracker Effect (when frame size changes) #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/CVTracker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,25 @@ bool CVTracker::trackFrame(cv::Mat &frame, size_t frameId)
cv::Mat gray;
cv::cvtColor(frame, gray, cv::COLOR_BGR2GRAY);

const bool prevGrayMatches =
!prevGray.empty() &&
prevGray.size() == gray.size() &&
prevGray.type() == gray.type();
const bool fullPrevGrayMatches =
!fullPrevGray.empty() &&
fullPrevGray.size() == gray.size() &&
fullPrevGray.type() == gray.type();

if (!prevGray.empty() && !prevGrayMatches) {
prevPts.clear();
lostCount = 0;
}

cv::Rect2d cand;
bool didKLT = false;

// Try KLT-based drift
if (!prevGray.empty() && !prevPts.empty()) {
if (prevGrayMatches && !prevPts.empty()) {
std::vector<cv::Point2f> currPts;
std::vector<uchar> status;
std::vector<float> err;
Expand Down Expand Up @@ -233,7 +247,7 @@ bool CVTracker::trackFrame(cv::Mat &frame, size_t frameId)
if (!didKLT) {
++lostCount;
cand = lastBox;
if (!fullPrevGray.empty()) {
if (fullPrevGrayMatches) {
cv::Mat flow;
cv::calcOpticalFlowFarneback(
fullPrevGray, gray, flow,
Expand Down
37 changes: 37 additions & 0 deletions tests/CVTracker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,43 @@ TEST_CASE( "Track_BoundingBoxClipping", "[libopenshot][opencv][tracker]" )
CHECK(tracker_pc.GetError() == false);
}

TEST_CASE( "Track_FrameSizeChangeDoesNotCrash", "[libopenshot][opencv][tracker]" )
{
std::string json_data = R"proto(
{
"tracker-type": "KCF",
"region": {
"normalized_x": 0.2,
"normalized_y": 0.2,
"normalized_width": 0.3,
"normalized_height": 0.3,
"first-frame": 1
}
} )proto";

ProcessingController tracker_pc;
CVTracker tracker(json_data, tracker_pc);

cv::Mat frame1(360, 640, CV_8UC3, cv::Scalar(0, 0, 0));
cv::rectangle(frame1, cv::Rect(128, 72, 160, 108), cv::Scalar(255, 255, 255), cv::FILLED);

cv::Mat frame2 = frame1.clone();

cv::Mat frame3(180, 320, CV_8UC3, cv::Scalar(0, 0, 0));
cv::rectangle(frame3, cv::Rect(64, 36, 80, 54), cv::Scalar(255, 255, 255), cv::FILLED);

REQUIRE_NOTHROW(tracker.initTracker(frame1, 1));
REQUIRE_NOTHROW(tracker.trackFrame(frame2, 2));
REQUIRE_NOTHROW(tracker.trackFrame(frame3, 3));

FrameData fd = tracker.GetTrackedData(3);
CHECK(fd.frame_id == 3);
CHECK(fd.x1 >= 0.0f);
CHECK(fd.y1 >= 0.0f);
CHECK(fd.x2 <= 1.0f);
CHECK(fd.y2 <= 1.0f);
}


TEST_CASE( "SaveLoad_Protobuf", "[libopenshot][opencv][tracker]" )
{
Expand Down
Loading