Skip to content

Fix: Improved robust handling of conical pipes #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dietmarw merged 1 commit into from
Apr 20, 2026
Merged

Fix: Improved robust handling of conical pipes #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions OpenHPL/Waterway/Pipe.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ model Pipe "Model of a pipe"

protected
parameter SI.Diameter D_ = ( D_i + D_o) / 2 "Average diameter";
parameter SI.Area A_i = D_i ^ 2 * C.pi / 4 "Inlet cross-sectional area";
parameter SI.Area A_o = D_o ^ 2 * C.pi / 4 "Outlet cross-sectional area";

parameter SI.Area A_ = D_ ^ 2 * C.pi / 4 "Average cross-sectional area";
parameter Real delta=2*(D_i-D_o)/(D_i+D_o) "Contraction factor";
parameter Real cf=1+2*delta^2 "Conical pipe function";
Expand All @@ -54,7 +53,7 @@ equation
Vdot = mdot / data.rho "Volumetric flow rate through the pipe";
v = Vdot / A_ "Average water velocity";
F_f = Functions.DarcyFriction.Friction(v, D_, L, data.rho, data.mu, p_eps)*cf "Friction force";
L * der(mdot)=(p_i+ data.rho *data.g * H)*A_i-p_o*A_o -F_f;
L * der(mdot)=(p_i+ data.rho *data.g * H-p_o)*A_ -F_f;
p_i = i.p "Inlet pressure";
p_o = o.p "Outlet pressure";
i.mdot+o.mdot = 0 "Mass balance";
Expand Down
Loading