Add required majority fields #3219
Conversation
Add some tests and add docs.
luisa-beerboom
left a comment
luisa-beerboom
left a comment
There was a problem hiding this comment.
I am guessing no_majority is the description for the system we had until now.
Given that it is also the default, why not just use None instead? I am guessing that would functionally work the same.
One enum value less, no default setting necessary since it will still be None if left empty (therefore one less loop the automatic action logic will have to go through), and no need to think about possibly having to migrate past polls.
|
I will look, if I can use the None case for 'no_majority'. |
The None case is used for the old behaviour/'no_majority'.
|
@luisa-beerboom Now the code uses the None case for the old behaviour. So I suppose, that no migration is needed. The default is None for the three fields. Please have a look. |
|
It shows that the missing of the 'no_majority' option complicates things in the client. So I revert it. |
This reverts commit 06d95fa.
|
Wouldn't you need a migration to fill in the field for old polls then? |
2 participants
Resolve #3199
Add some tests and add docs. Update the test data in some tests.
@luisa-beerboom please review.