Skip to content

Fix CRs for paragraphs with empty first line #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bastianjoel wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Fix CRs for paragraphs with empty first line #5340

bastianjoel wants to merge 28 commits into from

Conversation

@bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Aug 22, 2025 •
edited
Loading

@bastianjoel bastianjoel changed the title Fix CRs for paragraphs with empty br Fix CRs for paragraphs with empty first line Aug 26, 2025
@bastianjoel bastianjoel marked this pull request as ready for review August 26, 2025 07:45
@bastianjoel bastianjoel requested a review from Elblinator August 26, 2025 07:47
@bastianjoel bastianjoel mentioned this pull request Aug 26, 2025
Draft
3 tasks
@Elblinator Elblinator added the waiting Waiting for some other PR/feature; more details in comments label Aug 27, 2025
@Elblinator
Copy link
Member

Elblinator commented Aug 27, 2025

Do not merge yet

@Elblinator
Copy link
Member

Elblinator commented Aug 27, 2025

Please reassign me if approved

@Elblinator Elblinator removed their assignment Aug 27, 2025
@bastianjoel bastianjoel mentioned this pull request Aug 28, 2025
Open
@bastianjoel bastianjoel marked this pull request as draft September 30, 2025 13:46
@bastianjoel bastianjoel force-pushed the 5165-fix-empty-br branch 4 times, most recently from ed0db4d to 22867e2 Compare September 30, 2025 16:05
@bastianjoel bastianjoel requested a review from rrenkert October 6, 2025 15:06
@bastianjoel bastianjoel assigned bastianjoel and rrenkert and unassigned Elblinator Oct 6, 2025
@bastianjoel bastianjoel requested a review from MSoeb October 6, 2025 15:06
@bastianjoel bastianjoel removed the waiting Waiting for some other PR/feature; more details in comments label Oct 6, 2025
luisa-beerboom
luisa-beerboom approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, minor remarks though

@luisa-beerboom luisa-beerboom removed their assignment Oct 8, 2025
@bastianjoel bastianjoel removed their assignment Oct 8, 2025
@MSoeb
Copy link

MSoeb commented Oct 9, 2025

Found two issue during testing. Already talked with @bastianjoel about it. Full review follows. Need more test data.

  • If an instance has an old motion with amendments and change recos in it, an error appears in the console by opening it.
    Error Message: TypeError: Cannot read properties of undefined (reading 'replace')

  • In Chrome browser: If several new lines with SHIFT+ENTER are added to an existing motion, the gap between the lines is not visible. The motion looks like no empty lines exists.

@bastianjoel bastianjoel mentioned this pull request Oct 10, 2025
Closed
@bastianjoel
Copy link
Member Author

bastianjoel commented Oct 27, 2025

@MSoeb The requested changes are fixed now.

@Elblinator Elblinator removed their request for review November 3, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elblinator Elblinator Elblinator approved these changes

@luisa-beerboom luisa-beerboom luisa-beerboom approved these changes

@rrenkert rrenkert Awaiting requested review from rrenkert

@MSoeb MSoeb Awaiting requested review from MSoeb

Assignees

@rrenkert rrenkert

@MSoeb MSoeb

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Motion diff compatibility improvement Fix CRs for paragraphs with empty br Fix motions with empty br at the beginning of p

5 participants

@bastianjoel @Elblinator @MSoeb @luisa-beerboom @rrenkert