Skip to content

Run the legal-terms-privacy-policy suite in CI - #94

Merged
vtempest merged 1 commit into
masterfrom
claude/youthful-bardeen-clem3n
Sep 11, 2026
Merged

Run the legal-terms-privacy-policy suite in CI#94
vtempest merged 1 commit into
masterfrom
claude/youthful-bardeen-clem3n

Conversation

@vtempest

Copy link
Copy Markdown
Collaborator

The package landed on master without an entry in either test matrix, so its 41 tests were not running anywhere and its coverage was not reported.

Adds it to both workflows and gives it the test:ci script they invoke, plus a Codecov flag so its coverage carries forward like every other package's. Verified from a clean checkout: npm install --ignore-scripts --legacy-peer-deps then npm run test:ci passes and writes junit.xml and coverage/lcov.info.

Claude-Session: https://claude.ai/code/session_01G9u1uDQ4mVF6L3gyarMk7M

The package landed on master without an entry in either test matrix, so its
41 tests were not running anywhere and its coverage was not reported.

Adds it to both workflows and gives it the test:ci script they invoke, plus a
Codecov flag so its coverage carries forward like every other package's.
Verified from a clean checkout: `npm install --ignore-scripts --legacy-peer-deps`
then `npm run test:ci` passes and writes junit.xml and coverage/lcov.info.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G9u1uDQ4mVF6L3gyarMk7M
@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
app-demo Error Error Sep 11, 2026 2:37pm UTC
cccp-deployment Ready Ready Preview Sep 11, 2026 2:37pm UTC

@vtempest
vtempest merged commit 4e8b65c into master Sep 11, 2026
25 of 28 checks passed
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

❌ 28 Tests Failed:

Tests completed Failed Passed Skipped
287 28 259 0
View the full list of 28 ❄️ flaky test(s)
test/api.test.ts > SMS Verification API > Documentation Endpoints > should serve OpenAPI documentation

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00199s run time
AssertionError: expected 404 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 404

 ❯ test/api.test.ts:187:26
test/api.test.ts > SMS Verification API > Documentation Endpoints > should serve Swagger UI

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00678s run time
AssertionError: expected 'application/json' to contain 'text/html'

Expected: "text/html"
Received: "application/json"

 ❯ test/api.test.ts:202:47
test/api.test.ts > SMS Verification API > Health Check > should return health status

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.0521s run time
AssertionError: expected { success: true, …(3) } to match object { status: 'ok' }
(3 matching properties omitted from actual)

- Expected
+ Received

  {
-   "status": "ok",
+   "status": "healthy",
  }

 ❯ test/api.test.ts:23:20
test/api.test.ts > SMS Verification API > Send Verification Code > should accept Bearer token authentication

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00322s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/api.test.ts:66:26
test/api.test.ts > SMS Verification API > Send Verification Code > should accept blockVoip parameter

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00262s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/api.test.ts:107:26
test/api.test.ts > SMS Verification API > Send Verification Code > should format phone number correctly

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00245s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/api.test.ts:94:26
test/api.test.ts > SMS Verification API > Send Verification Code > should handle blockVoip=false parameter

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00899s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/api.test.ts:120:26
test/api.test.ts > SMS Verification API > Send Verification Code > should reject invalid API key

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00527s run time
AssertionError: expected { success: false, …(2) } to match object { error: 'Invalid API key' }
(2 matching properties omitted from actual)

- Expected
+ Received

  {
-   "error": "Invalid API key",
+   "error": "Unauthorized",
  }

 ❯ test/api.test.ts:52:20
test/api.test.ts > SMS Verification API > Send Verification Code > should reject invalid phone number format

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00257s run time
AssertionError: expected 401 to be 400 // Object.is equality

- Expected
+ Received

- 400
+ 401

 ❯ test/api.test.ts:79:26
test/api.test.ts > SMS Verification API > Send Verification Code > should require API key authentication

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00436s run time
AssertionError: expected { success: false, …(2) } to match object { error: 'API key required' }
(2 matching properties omitted from actual)

- Expected
+ Received

  {
-   "error": "API key required",
+   "error": "Unauthorized",
  }

 ❯ test/api.test.ts:37:20
test/api.test.ts > SMS Verification API > Verify Code > should accept Bearer token authentication

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00162s run time
AssertionError: expected 401 to be 400 // Object.is equality

- Expected
+ Received

- 400
+ 401

 ❯ test/api.test.ts:176:26
test/api.test.ts > SMS Verification API > Verify Code > should reject invalid API key

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00331s run time
AssertionError: expected { success: false, …(2) } to match object { error: 'Invalid API key' }
(2 matching properties omitted from actual)

- Expected
+ Received

  {
-   "error": "Invalid API key",
+   "error": "Unauthorized",
  }

 ❯ test/api.test.ts:147:20
test/api.test.ts > SMS Verification API > Verify Code > should reject invalid phone number format

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00188s run time
AssertionError: expected 401 to be 400 // Object.is equality

- Expected
+ Received

- 400
+ 401

 ❯ test/api.test.ts:161:26
test/api.test.ts > SMS Verification API > Verify Code > should require API key authentication

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00339s run time
AssertionError: expected { success: false, …(2) } to match object { error: 'API key required' }
(2 matching properties omitted from actual)

- Expected
+ Received

  {
-   "error": "API key required",
+   "error": "Unauthorized",
  }

 ❯ test/api.test.ts:132:20
test/integration.test.ts > SMS Verification API Integration Tests > API Endpoints > should handle send verification endpoint

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00242s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/integration.test.ts:127:26
test/integration.test.ts > SMS Verification API Integration Tests > API Endpoints > should handle verify code endpoint

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00297s run time
AssertionError: expected 401 to be 400 // Object.is equality

- Expected
+ Received

- 400
+ 401

 ❯ test/integration.test.ts:148:26
test/integration.test.ts > SMS Verification API Integration Tests > Authentication Methods > should accept both X-API-Key and Bearer token headers

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.0778s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/integration.test.ts:24:27
test/integration.test.ts > SMS Verification API Integration Tests > Authentication Methods > should reject requests with invalid authentication

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00332s run time
AssertionError: expected 'Unauthorized' to be 'Invalid API key' // Object.is equality

Expected: "Invalid API key"
Received: "Unauthorized"

 ❯ test/integration.test.ts:63:26
test/integration.test.ts > SMS Verification API Integration Tests > Authentication Methods > should reject requests without authentication

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00444s run time
AssertionError: expected 'Unauthorized' to be 'API key required' // Object.is equality

Expected: "API key required"
Received: "Unauthorized"

 ❯ test/integration.test.ts:48:26
test/integration.test.ts > SMS Verification API Integration Tests > Phone Number Formatting > should format various phone number formats correctly

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00467s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/integration.test.ts:86:28
test/integration.test.ts > SMS Verification API Integration Tests > Phone Number Formatting > should reject clearly invalid phone numbers

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00245s run time
AssertionError: expected 401 to be 400 // Object.is equality

- Expected
+ Received

- 400
+ 401

 ❯ test/integration.test.ts:109:28
test/server.test.ts > SMS Verification API Server > API Authentication > should require API key for protected endpoints

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.0106s run time
AssertionError: expected 500 to be 401 // Object.is equality

- Expected
+ Received

- 401
+ 500

 ❯ test/server.test.ts:55:26
test/server.test.ts > SMS Verification API Server > Documentation > should serve OpenAPI documentation

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00367s run time
AssertionError: expected 500 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 500

 ❯ test/server.test.ts:78:26
test/server.test.ts > SMS Verification API Server > Error Handling > should return 404 for non-existent endpoints

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00336s run time
SyntaxError: Unexpected non-whitespace character after JSON at position 4
 ❯ test/server.test.ts:85:25
test/voip.test.ts > VoIP Blocking Functionality > VoIP detection logic > should correctly identify VoIP numbers

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.197s run time
AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ test/voip.test.ts:77:22
test/voip.test.ts > VoIP Blocking Functionality > blockVoip parameter > should accept blockVoip=true parameter

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.00222s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/voip.test.ts:47:26
test/voip.test.ts > VoIP Blocking Functionality > blockVoip parameter > should allow requests when blockVoip is false

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.0022s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/voip.test.ts:34:26
test/voip.test.ts > VoIP Blocking Functionality > blockVoip parameter > should allow requests when blockVoip is not specified

Flake rate in main: 100.00% (Passed 0 times, Failed 43 times)

Stack Traces | 0.0296s run time
AssertionError: expected 401 to be 200 // Object.is equality

- Expected
+ Received

- 200
+ 401

 ❯ test/voip.test.ts:21:26

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@vtempest
vtempest deleted the claude/youthful-bardeen-clem3n branch September 12, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants