Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the windfield-related fixes documented in Bugs.md, improving correctness and operational usability of the Mann-model turbulence cache in AtmosphericModels.jl by making windfield files smaller, better keyed to settings, and stored in a shared scratchspace.
Changes:
- Move
.npzwindfield storage fromget_data_path()to aScratch.jlscratchspace (windfield_path()), with an override viaset_windfield_path!. - Change windfield naming to include a settings digest (
param_digest) and removeuse_turbulencefrom the filename; also stop storingx/y/zmeshgrids in.npzand rebuild axes viagrid_axes. - Validate settings up front (
check_windfield_settings) and fix turbulence scaling/indexing to use the speed the loaded field was generated for (wf.v_wind_gnd) when applyingrel_turbs.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/windfield.jl |
Core implementation updates: scratchspace pathing, digest-based naming, reduced .npz contents, settings validation, and corrected turbulence scaling/source speed. |
src/AtmosphericModels.jl |
Exports/imports for new functionality (Scratch, SHA, windfield_path, set_windfield_path!) and WindField struct extension (v_wind_gnd). |
test/test_windfield.jl |
Expanded tests for new naming/path behavior, settings validation, digest behavior, axis rebuilding, and rel_turbs source correctness. |
Project.toml |
Version bump to 0.3.8 and added deps/compat for Scratch and SHA. |
examples/menu.jl |
Update windfield deletion helper to target windfield_path() rather than data/. |
examples/load_windfield.jl |
Update example for new load_windfield return shape and axis reconstruction. |
docs/src/wind_field.md |
Documentation updated for scratchspace storage, digest naming, and lookup-time turbulence scaling. |
docs/src/api.md |
API docs updated to list new functions and relevant internal helpers. |
CLAUDE.md |
Repository guidance updated to reflect new grid_axes/storage/name conventions. |
CHANGELOG.md |
Adds an unreleased v0.3.8 entry documenting behavior and migration notes. |
Bugs.md |
Marks reported bugs as addressed in v0.3.8 and documents the implemented resolutions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details, see Bugs.md
In addition, a vector version of get_wind was added.
The interpolate keyword works now.