Skip to content

Large bugfix PR - #32

Merged
ufechner7 merged 3 commits into
mainfrom
pre-0.3.8
Aug 9, 2026
Merged

Large bugfix PR#32
ufechner7 merged 3 commits into
mainfrom
pre-0.3.8

Conversation

@ufechner7

@ufechner7 ufechner7 commented Aug 9, 2026

Copy link
Copy Markdown
Member

For details, see Bugs.md
In addition, a vector version of get_wind was added.
The interpolate keyword works now.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements the windfield-related fixes documented in Bugs.md, improving correctness and operational usability of the Mann-model turbulence cache in AtmosphericModels.jl by making windfield files smaller, better keyed to settings, and stored in a shared scratchspace.

Changes:

  • Move .npz windfield storage from get_data_path() to a Scratch.jl scratchspace (windfield_path()), with an override via set_windfield_path!.
  • Change windfield naming to include a settings digest (param_digest) and remove use_turbulence from the filename; also stop storing x/y/z meshgrids in .npz and rebuild axes via grid_axes.
  • Validate settings up front (check_windfield_settings) and fix turbulence scaling/indexing to use the speed the loaded field was generated for (wf.v_wind_gnd) when applying rel_turbs.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/windfield.jl Core implementation updates: scratchspace pathing, digest-based naming, reduced .npz contents, settings validation, and corrected turbulence scaling/source speed.
src/AtmosphericModels.jl Exports/imports for new functionality (Scratch, SHA, windfield_path, set_windfield_path!) and WindField struct extension (v_wind_gnd).
test/test_windfield.jl Expanded tests for new naming/path behavior, settings validation, digest behavior, axis rebuilding, and rel_turbs source correctness.
Project.toml Version bump to 0.3.8 and added deps/compat for Scratch and SHA.
examples/menu.jl Update windfield deletion helper to target windfield_path() rather than data/.
examples/load_windfield.jl Update example for new load_windfield return shape and axis reconstruction.
docs/src/wind_field.md Documentation updated for scratchspace storage, digest naming, and lookup-time turbulence scaling.
docs/src/api.md API docs updated to list new functions and relevant internal helpers.
CLAUDE.md Repository guidance updated to reflect new grid_axes/storage/name conventions.
CHANGELOG.md Adds an unreleased v0.3.8 entry documenting behavior and migration notes.
Bugs.md Marks reported bugs as addressed in v0.3.8 and documents the implemented resolutions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/test_windfield.jl Outdated
@ufechner7
ufechner7 merged commit 03014f6 into main Aug 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants