Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Is this still up to date or did we get more changes in main? |
|
No, it is out of date. Main gained #54 after this branch was cut (merged 2026-10-15, 4 commits: bf36f22, @56535a0, @56ce4e2, @cec7413). Its changelog fragment changelog.d/KiteGeometry.jl-53.md has two BREAKING entries (follows awesIO 0.1.0 and its renamed fields; load_authoring now puts the kite at zenith). None of that is in this PR's v0.1.2 notes. The merge itself would go through without conflicts, but it would register v0.1.2 with breaking changes and a leftover fragment. Below 1.0 a BREAKING change means a minor bump, so the release should be v0.2.0. My recommendation: close #55 unmerged and I open a fresh bump with agent release 0.2.0 off current main. Say the word and I will. |
1-Bort-1
left a comment
There was a problem hiding this comment.
Independent review (advisory)
Verdict: APPROVE · 0 inline, 0 off the diff
Good
- Release-bump PR of the kind §9 allows: the only
versionchange is0.1.1→0.1.2inProject.toml, onrelease/v0.1.2. - Same shape as the v0.1.1 release (eaa3d9e): three files, +7/−4, the changelog.d fragment moved into a dated
CHANGELOG.mdsection. Checked withgit show --staton both commits. - The
### Fixedentry is the deletedchangelog.d/SymbolicAWEModels.jl-412.mdfragment word for word, so no wording drifted while it moved. changelog.d/is empty after this commit, so no pending fragment was left out of the release.- The release covers only #52 (205fe9d, reading a model field of one number or one per axis), the one change merged since v0.1.1.
Not good
- The PR card is empty ("No card was written"). A release PR is self-describing, but AGENTS.md §6 still expects a card stating what is being released.
- Date formats differ: the v0.1.1 and v0.1.2 headings use ISO
2026-10-15but v0.1.0 uses09-10-2026. This was already there before this PR, but it is in a file this PR opens, so it is around-the-change tidying the PR could have done.
claude, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.
|
Local full suite: PASS (1 min, Julia 1.13.0, one cell of the matrix) |
The other release headers use YYYY-MM-DD; 09-10-2026 read as 9 October. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The description above is this branch as it stands. Commits
|
|
Yeah I agree, I will close this PR. But also open an issue on Agents, a release PR should merge in latest main always such that this cannot happen. |
|
Opened 1-Bart-1/Agents#686 for it. The v0.2.0 bump from main is already open as #56. |
This releases one fix: a model field that accepts either one number or one number per axis now reads a cell holding either form, where both used to fail with a
MethodError. It also writes the v0.1.0 date in the changelog as2026-10-09, the year-first form every other release header uses.Out of date with main, so this should not merge as is. Main gained #54 after this branch was cut. Its notes carry two breaking changes: the structure document follows awesIO 0.1.0 and its renamed fields, and the authoring loader now places the kite at zenith. Neither is in these notes. Below 1.0 a breaking change makes the next release a minor one, so the release that ships both is v0.2.0. My recommendation is to close this and let me open the v0.2.0 bump from main; say so and I will.
Verification
reusetool is not installed on this machine);CHANGELOG.mdkeeps its SPDX headerOpened by
1-Bort-1, an AI agent working for @1-Bart-1.Task
KiteGeometry.jl-55