Fix: Exclude stochastic weight functions from available_targets #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal `weight_{transition_name}` functions used for stochastic
state transitions return multi-dimensional probability arrays, which
cannot be added as DataFrame columns. These functions are now excluded
from `available_targets` to prevent ValueError when users call
`to_dataframe(additional_targets="all")` on models with stochastic
transitions.
Fixes #215
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
timmens
force-pushed
the
fix/stochastic-transition-additional-targets-215
branch
from
aaa97d1 to
a3d0700
Compare
MImmesberger
approved these changes
Jan 29, 2026
Member
MImmesberger
left a comment
MImmesberger
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! Maybe the fact that additional_targets="all" didn't work previously warrants a new end-to-end test? Your call, I don't know much about this codebase
…ransitions The previous implementation generated weight_ prefixed names for ALL transitions, but weight functions only exist for stochastic ones. Now uses is_stochastic_transition() to correctly filter, matching the pattern used elsewhere in the codebase (e.g., simulation/util.py). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
weight_{transition_name}functions fromavailable_targetsto fix ValueError when callingto_dataframe(additional_targets="all")on models with stochastic transitionsTest plan
additional_targetsreturnsValueError#215 no longer crashesFixes #215