Remove fade value and use animation for checkbox#208
Open
ylvaselling wants to merge 1 commit intomasterfrom
Open
Remove fade value and use animation for checkbox#208ylvaselling wants to merge 1 commit intomasterfrom
ylvaselling wants to merge 1 commit intomasterfrom
Conversation
alexanderbock
approved these changes
Mar 30, 2026
Collaborator
WeirdRubberDuck
left a comment
There was a problem hiding this comment.
Nice! The animation shows an ugly "jack" when the icon size is increased, however. It would be great if we could fix this now rather than later, to make the component more usable.
It might be solvable by just increasing the background size to make sure the edge is never visible
Here's how it looks for an md sized icon:
incon.mp4
Otherwise, it looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the fading checkbox from this:
2026-03-30.11-07-52.mp4
To this:
2026-03-30.11-07-34.mp4
This has the benefit of: